app/models/membership.rb
Class Membership
has 21 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class Membership < DagLink
alias_attribute :user_id, :descendant_id
alias_attribute :user, :descendant
alias_attribute :group_id, :ancestor_id
Method find_all_by
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def self.find_all_by( params )
user = params[ :user ]
user ||= User.find params[:user_id] if params[:user_id]
user ||= User.find_by_title params[:user_title] if params[:user_title]
group = params[ :group ]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"