app/models/user.rb
Class User
has 74 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class User < ApplicationRecord
# Virtual attribute, which can be used in member lists to add a note in memory when the user
# has joined a group or list.
#
File user.rb
has 381 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
class User < ApplicationRecord
# Virtual attribute, which can be used in member lists to add a note in memory when the user
# has joined a group or list.
#
Method update_last_seen_activity
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def update_last_seen_activity(description = nil, object = nil)
unless readonly?
if description and not self.incognito?
activity = find_or_build_last_seen_activity
activity.touch unless activity.new_record? # even if the attributes didn't change. The user probably hit 'reload' then.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"