filestack/filestack-php

View on GitHub
tests/FilestackClientTest.php

Summary

Maintainability
F
4 days
Test Coverage

File FilestackClientTest.php has 779 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace Filestack\Tests;

use Filestack\FilestackClient;
use Filestack\FilestackSecurity;
Severity: Major
Found in tests/FilestackClientTest.php - About 1 day to fix

    FilestackClientTest has 38 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class FilestackClientTest extends BaseTest
    {
        /**
         * Test initializing FilestackClient with an API Key
         */
    Severity: Minor
    Found in tests/FilestackClientTest.php - About 5 hrs to fix

      Method testCollageSuccess has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function testCollageSuccess()
          {
              $mock_response = new MockHttpResponse(
                  200,
                  '{"url": "http://cdn.filestackcontent.com/somehandle",'.
      Severity: Minor
      Found in tests/FilestackClientTest.php - About 1 hr to fix

        Method testUploadIntelligentSuccess has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testUploadIntelligentSuccess()
            {
                $mock_response_202 = new MockHttpResponse(202,  '{accepted: true}');
                $mock_response = new MockHttpResponse(200,
                    json_encode([
        Severity: Minor
        Found in tests/FilestackClientTest.php - About 1 hr to fix

          Method testconvertVideoSuccess has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function testconvertVideoSuccess()
              {
                  $mock_response = new MockHttpResponse(
                      200,
                      '{"uuid" : "some_uuid", "conversion_url": "http://someurl.com/handle"}'
          Severity: Minor
          Found in tests/FilestackClientTest.php - About 1 hr to fix

            Method testUploadSuccessWithOptions has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testUploadSuccessWithOptions()
                {
                    $test_headers = ['ETag' =>['some-etag']];
                    $mock_response = new MockHttpResponse(200,
                        json_encode([
            Severity: Minor
            Found in tests/FilestackClientTest.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function testOverwriteSuccess()
                  {
                      $mock_response = new MockHttpResponse(
                          200,
                          json_encode([
              Severity: Major
              Found in tests/FilestackClientTest.php and 1 other location - About 2 hrs to fix
              tests/FilestackClientTest.php on lines 872..896

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 133.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function testOverwriteUrlSuccess()
                  {
                      $mock_response = new MockHttpResponse(
                          200,
                          json_encode([
              Severity: Major
              Found in tests/FilestackClientTest.php and 1 other location - About 2 hrs to fix
              tests/FilestackClientTest.php on lines 816..839

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 133.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function testGetMetadataException()
                  {
                      $mock_response = new MockHttpResponse(
                          400,
                          'Bad Request'
              Severity: Major
              Found in tests/FilestackClientTest.php and 1 other location - About 1 hr to fix
              tests/FilestackClientTest.php on lines 117..136

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function testGetContentNotFound()
                  {
                      $mock_response = new MockHttpResponse(
                          404,
                          'File not found'
              Severity: Major
              Found in tests/FilestackClientTest.php and 1 other location - About 1 hr to fix
              tests/FilestackClientTest.php on lines 255..275

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function testGetTagsException()
                  {
                      $mock_response = new MockHttpResponse(404);
              
                      $stub_http_client = $this->createMock(\GuzzleHttp\Client::class);
              Severity: Major
              Found in tests/FilestackClientTest.php and 1 other location - About 1 hr to fix
              tests/FilestackClientTest.php on lines 187..204

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function testGetSfwException()
                  {
                      $mock_response = new MockHttpResponse(404);
              
                      $stub_http_client = $this->createMock(\GuzzleHttp\Client::class);
              Severity: Major
              Found in tests/FilestackClientTest.php and 1 other location - About 1 hr to fix
              tests/FilestackClientTest.php on lines 233..250

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function testGetSfwSuccess()
                  {
                      $mock_response = new MockHttpResponse(
                          200,
                          '{"sfw": true}'
              Severity: Minor
              Found in tests/FilestackClientTest.php and 1 other location - About 1 hr to fix
              tests/FilestackClientTest.php on lines 209..228

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 100.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function testGetTagsSuccess()
                  {
                      $mock_response = new MockHttpResponse(
                          200,
                          '{"tags": "sometags"}'
              Severity: Minor
              Found in tests/FilestackClientTest.php and 1 other location - About 1 hr to fix
              tests/FilestackClientTest.php on lines 164..182

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 100.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status