Sign upLogin

filestack/filestack-swift

View on GitHub
Star
Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift

Summary

Maintainability
C
1 day
Test Coverage

Function submitChunk has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    func submitChunk(chunkOffset: UInt64, chunkSize: Int, retries: Int = Defaults.maxRetries) -> SubmitChunkUploadOperation? {
        guard !isCancelled else { return nil }

        guard retries > 0 else {
            finish(with: .failure(.custom("Exceeded max retries trying to submit data chunk.")))
Severity: Minor
Found in Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function submitChunk has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func submitChunk(chunkOffset: UInt64, chunkSize: Int, retries: Int = Defaults.maxRetries) -> SubmitChunkUploadOperation? {
        guard !isCancelled else { return nil }

        guard retries > 0 else {
            finish(with: .failure(.custom("Exceeded max retries trying to submit data chunk.")))
Severity: Minor
Found in Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

            return operation
    Severity: Major
    Found in Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                                             retries: retries - 1) != nil else { return }
      Severity: Major
      Found in Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift - About 30 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            required init(number: Int, size: Int, offset: UInt64, descriptor: UploadDescriptor) {
        self.number = number
        self.size = size
        self.offset = offset
        self.descriptor = descriptor
        Severity: Minor
        Found in Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift and 1 other location - About 45 mins to fix
        Sources/FilestackSDK/Internal/Operations/SubmitPartRegularUploadOperation.swift on lines 33..40

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    switch commitOperation.result {
            case let .success(response):
                self.finish(with: .success(response))
            case let .failure(error):
                self.finish(with: .failure(error))
        Severity: Minor
        Found in Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift and 1 other location - About 45 mins to fix
        Sources/FilestackSDK/Internal/Operations/UploadOperation.swift on lines 108..113

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private lazy var chunkUploadOperationQueue: OperationQueue = {
        let queue = OperationQueue()

        queue.maxConcurrentOperationCount = descriptor.options.chunkUploadConcurrency
        Severity: Minor
        Found in Sources/FilestackSDK/Internal/Operations/SubmitPartIntelligentUploadOperation.swift and 1 other location - About 30 mins to fix
        Sources/FilestackSDK/Internal/Operations/SubmitPartsUploadOperation.swift on lines 20..26

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 40.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status