filestack/filestack-swift

View on GitHub
Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift

Summary

Maintainability
C
1 day
Test Coverage

Function uploadMultipleURLs has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    @objc public func uploadMultipleURLs(using localURLs: [NSURL],
                                         options: UploadOptions = .defaults,
                                         queue: DispatchQueue = .main,
                                         uploadProgress: ((Progress) -> Void)? = nil,
                                         completionHandler: @escaping ([JSONResponse]) -> Void) -> Uploader {
Severity: Minor
Found in Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift - About 35 mins to fix

    Function uploadData has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        @objc public func uploadData(using data: NSData,
                                     options: UploadOptions = .defaults,
                                     queue: DispatchQueue = .main,
                                     uploadProgress: ((Progress) -> Void)? = nil,
                                     completionHandler: @escaping (JSONResponse) -> Void) -> Uploader {
    Severity: Minor
    Found in Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift - About 35 mins to fix

      Function uploadURL has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          @objc public func uploadURL(using localURL: NSURL,
                                      options: UploadOptions = .defaults,
                                      queue: DispatchQueue = .main,
                                      uploadProgress: ((Progress) -> Void)? = nil,
                                      completionHandler: @escaping (JSONResponse) -> Void) -> Uploader {
      Severity: Minor
      Found in Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift - About 35 mins to fix

        Function uploadMultipleData has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            @objc public func uploadMultipleData(using multipleData: [NSData],
                                                 options: UploadOptions = .defaults,
                                                 queue: DispatchQueue = .main,
                                                 uploadProgress: ((Progress) -> Void)? = nil,
                                                 completionHandler: @escaping ([JSONResponse]) -> Void) -> Uploader {
        Severity: Minor
        Found in Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @discardableResult
              @objc public func uploadMultipleURLs(using localURLs: [NSURL],
                                                   options: UploadOptions = .defaults,
                                                   queue: DispatchQueue = .main,
                                                   uploadProgress: ((Progress) -> Void)? = nil,
          Severity: Major
          Found in Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift and 1 other location - About 1 hr to fix
          Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift on lines 133..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @discardableResult
              @objc public func uploadMultipleData(using multipleData: [NSData],
                                                   options: UploadOptions = .defaults,
                                                   queue: DispatchQueue = .main,
                                                   uploadProgress: ((Progress) -> Void)? = nil,
          Severity: Major
          Found in Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift and 1 other location - About 1 hr to fix
          Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift on lines 67..78

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @discardableResult
              @objc public func uploadData(using data: NSData,
                                           options: UploadOptions = .defaults,
                                           queue: DispatchQueue = .main,
                                           uploadProgress: ((Progress) -> Void)? = nil,
          Severity: Major
          Found in Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift and 1 other location - About 1 hr to fix
          Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift on lines 34..45

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @discardableResult
              @objc public func uploadURL(using localURL: NSURL,
                                          options: UploadOptions = .defaults,
                                          queue: DispatchQueue = .main,
                                          uploadProgress: ((Progress) -> Void)? = nil,
          Severity: Major
          Found in Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift and 1 other location - About 1 hr to fix
          Sources/FilestackSDK/Public/Extensions/Client+ObjC.swift on lines 100..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 110.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status