finally-a-fast/faftephp

ElementSetting has 24 functions (exceeds 20 allowed). Consider refactoring.

Open

class ElementSetting extends BaseObject
{
    /**
     * @var string
     */

Avoid excessively long variable names like $multipleAttributeExpression. Keep variable name length under 20.

Open

    public function setMultipleAttributeExpression(string $multipleAttributeExpression): self

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $multipleAttributeExpression. Keep variable name length under 20.

Open

    public string $multipleAttributeExpression = '/^{{name}}(-(.*))?$/i';

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

The 'getMultiple()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getMultiple(): bool
    {
        return $this->multiple;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getSafeData()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getSafeData(): bool
    {
        return $this->safeData;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getRawData()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getRawData(): bool
    {
        return $this->rawData;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getAttributeNameAsKey()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getAttributeNameAsKey(): bool
    {
        return $this->attributeNameAsKey;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}