Sign upLogin

finos/greenkey-intercom-sdk

View on GitHub
Star

Showing 4 of 4 total issues

File app.js has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable no-console */
/* global document */
import GreenKey from 'greenkey-intercom-sdk';

const endpoint = 'replace me';
Severity: Minor
Found in examples/es6/app.js - About 2 hrs to fix

    Function connectIntercoms has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      connectIntercoms({ id, endpoint, protocol, port }) {
    return new Promise((resolve) => {
      const transportOptions = {
        traceSip: false,
        wsServers: [`${protocol}://${endpoint}:${port}`],
    Severity: Minor
    Found in sdk.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        GK.events.on('intercoms.connected', (e) => {
    console.log('intercoms.connected ::', e);
    changeUserStatus(e.id, 'connected');
  });
      Severity: Minor
      Found in examples/es6/app.js and 1 other location - About 35 mins to fix
      examples/es6/app.js on lines 82..85

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        GK.events.on('intercoms.disconnected', (e) => {
    console.log('intercoms.disconnected ::', e);
    changeUserStatus(e.id, 'disconnected');
  });
      Severity: Minor
      Found in examples/es6/app.js and 1 other location - About 35 mins to fix
      examples/es6/app.js on lines 78..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language