Sign upLogin

firasdarwish/ore

View on GitHub
Star

Showing 6 of 6 total issues

Function BuildContainerDo has 12 return statements (exceeds 4 allowed).
Open

func BuildContainerDo() do.Injector {
    injector := do.New()
    do.ProvideTransient(injector, func(inj do.Injector) (*A, error) {
        return NewA(do.MustInvoke[*B](inj), do.MustInvoke[*C](inj)), nil
    })
Severity: Major
Found in examples/benchperf/internal/DiSamber.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package models

import (
    "context"
    "github.com/firasdarwish/ore/internal/interfaces"
    Severity: Major
    Found in internal/models/simple_counter.go and 1 other location - About 1 hr to fix
    internal/models/simple_counter2.go on lines 1..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package models

import (
    "context"
    "github.com/firasdarwish/ore/internal/interfaces"
    Severity: Major
    Found in internal/models/simple_counter2.go and 1 other location - About 1 hr to fix
    internal/models/simple_counter.go on lines 1..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function RegisterToOreContainer has 11 return statements (exceeds 4 allowed).
    Open

    func RegisterToOreContainer(container *ore.Container) {
    ore.RegisterFuncToContainer(container, ore.Transient, func(ctx context.Context) (*A, context.Context) {
        b, ctx := ore.GetFromContainer[*B](container, ctx)
        c, ctx := ore.GetFromContainer[*C](container, ctx)
        return NewA(b, c), ctx
    Severity: Major
    Found in examples/benchperf/internal/DiOre.go - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          ore.RegisterFuncToContainer(container, ore.Transient, func(ctx context.Context) (*B, context.Context) {
        d, ctx := ore.GetFromContainer[*D](container, ctx)
        e, ctx := ore.GetFromContainer[*E](container, ctx)
        return NewB(d, e), ctx
    })
      Severity: Minor
      Found in examples/benchperf/internal/DiOre.go and 1 other location - About 30 mins to fix
      examples/benchperf/internal/DiOre.go on lines 17..21

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          ore.RegisterFuncToContainer(container, ore.Transient, func(ctx context.Context) (*A, context.Context) {
        b, ctx := ore.GetFromContainer[*B](container, ctx)
        c, ctx := ore.GetFromContainer[*C](container, ctx)
        return NewA(b, c), ctx
    })
      Severity: Minor
      Found in examples/benchperf/internal/DiOre.go and 1 other location - About 30 mins to fix
      examples/benchperf/internal/DiOre.go on lines 22..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language