Sign upLogin

firebase/emberfire

View on GitHub
Star
addon/services/realtime-listener.ts

Summary

Maintainability
D
3 days
Test Coverage

Function subscribe has 176 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    subscribe(route: Object, model: any, parentModel?: any, relationship?:any) {
        if (!model) { return }
        const store = model.store as DS.Store;
        const modelName = (model.get('type.modelName') || model.get('_internalModel.modelName') || model.modelName) as never
        const modelClass = store.modelFor(modelName) as any;
Severity: Major
Found in addon/services/realtime-listener.ts - About 7 hrs to fix

    Function subscribe has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
    Open

        subscribe(route: Object, model: any, parentModel?: any, relationship?:any) {
        if (!model) { return }
        const store = model.store as DS.Store;
        const modelName = (model.get('type.modelName') || model.get('_internalModel.modelName') || model.modelName) as never
        const modelClass = store.modelFor(modelName) as any;
    Severity: Minor
    Found in addon/services/realtime-listener.ts - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function unsubscribe has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                        const unsubscribe = query.onSnapshot(snapshot => {
                        snapshot.docChanges().forEach(change => run(() => {
                            const normalizedData = serializer.normalizeSingleResponse(store, modelClass, change.doc);
                            switch(change.type) {
                                case 'added': {
    Severity: Minor
    Found in addon/services/realtime-listener.ts - About 1 hr to fix

      Function observeRelationships has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              const observeRelationships = (internalModel: any) => {
            // HACK HACK HACK
            const movedKey = '__original___updatePromiseProxyFor';
            const proxyPromiseListenersKey = `_updatePromiseProxyListeners`;
            const requestedRelationshipsKey = '_requestedRelationships';
      Severity: Minor
      Found in addon/services/realtime-listener.ts - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                        if (record) { store.deleteRecord(record) }
        Severity: Major
        Found in addon/services/realtime-listener.ts - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                          if (current == null || current.id !== doc.id ) {
                                    content.insertAt(insertIndex, doc._internalModel);
                                }
          Severity: Major
          Found in addon/services/realtime-listener.ts - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                            if (existing) { content.removeObject(existing); }
            Severity: Major
            Found in addon/services/realtime-listener.ts - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                              if (existing) { content.removeObject(existing); }
              Severity: Major
              Found in addon/services/realtime-listener.ts - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                                if (priorKey) {
                                    const record = content.find((record:any) => record.id === priorKey);
                                    const index = content.indexOf(record);
                                    content.insertAt(index+1, doc._internalModel);
                                } else {
                Severity: Major
                Found in addon/services/realtime-listener.ts - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                          if (change.newIndex !== change.oldIndex) {
                                            content.removeAt(change.oldIndex);
                                            content.insertAt(change.newIndex, current)
                                        }
                  Severity: Major
                  Found in addon/services/realtime-listener.ts - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                    if (record) { content.removeObject(record); }
                    Severity: Major
                    Found in addon/services/realtime-listener.ts - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                      if (priorKey) {
                                    const record = content.find((record:any) => record.id === priorKey);
                                    insertIndex = content.indexOf(record) + 1;
                                }
                      Severity: Major
                      Found in addon/services/realtime-listener.ts - About 45 mins to fix

                        Function unsubscribeRoute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                        const unsubscribeRoute = (service: RealtimeListenerService, route: Object, uniqueIdentifier?: string) => {
    const routeSubscriptions = get(service, `routeSubscriptions`);
    const existingSubscriptions = get(routeSubscriptions, route.toString());
    if (existingSubscriptions) {
        if (uniqueIdentifier) {
                        Severity: Minor
                        Found in addon/services/realtime-listener.ts - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        export const subscribe = (route: Object, model: DS.Model) => !isFastboot(route) && getService(route).subscribe(route, model);
                        Severity: Minor
                        Found in addon/services/realtime-listener.ts and 1 other location - About 55 mins to fix
                        addon/services/realtime-listener.ts on lines 20..20

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 54.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        export const unsubscribe = (route: Object, model?: DS.Model) => !isFastboot(route) && getService(route).unsubscribe(route, model);
                        Severity: Minor
                        Found in addon/services/realtime-listener.ts and 1 other location - About 55 mins to fix
                        addon/services/realtime-listener.ts on lines 19..19

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 54.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status