Sign upLogin

fireguard/form

View on GitHub
Star

Showing 12 of 12 total issues

Form has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class Form
{
    /**
     * @var FormModelInterface
     */
Severity: Minor
Found in src/Form/Form.php - About 2 hrs to fix

    Method testRender has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function testRender()
    {
        $element = new SelectElement('name-for-select');
        $this->assertEquals(
            '<div id="name-for-select-form-group" class="form-group" ><select  name="name-for-select" id="name-for-select-id" class="form-control "><option value="" selected="selected"></option></select><div class="error-message" id="name-for-select-input-message"></div></div>',
    Severity: Minor
    Found in tests/Form/Elements/SelectElementTest.php - About 1 hr to fix

      Method testRender has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function testRender()
    {
        $element = new ButtonElement('name-for-btn');
        $this->assertEquals(
            '<button  name="name-for-btn" type="button" class="btn btn-default"> name-for-btn</button>',
      Severity: Minor
      Found in tests/Form/Elements/ButtonElementTest.php - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                $form->addGroup('test-elements', [
            ['checkbox1', CheckBoxElement::class, ['lable' => 'Checkbox1', 'inline' => true], true],
            ['checkbox2', CheckBoxElement::class, ['lable' => 'Checkbox2', 'inline' => true], false]
        ], ['label' => 'Name for Group']);
        Severity: Minor
        Found in tests/Form/Elements/GroupElementTest.php and 1 other location - About 40 mins to fix
        tests/Form/Elements/GroupElementTest.php on lines 54..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                $form->addGroup('test-elements', [
            ['checkbox1', CheckBoxElement::class, ['lable' => 'Checkbox1', 'inline' => true], true],
            ['checkbox2', CheckBoxElement::class, ['lable' => 'Checkbox2', 'inline' => true], false]
        ], ['label' => 'Name for Group']);
        Severity: Minor
        Found in tests/Form/Elements/GroupElementTest.php and 1 other location - About 40 mins to fix
        tests/Form/Elements/GroupElementTest.php on lines 68..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this method.
        Open

                    case 'link': return 'btn-link';
        Severity: Major
        Found in src/Form/Elements/ButtonElement.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      case 'info': return 'btn-info';
          Severity: Major
          Found in src/Form/Elements/ButtonElement.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        default: return 'btn-default';
            Severity: Major
            Found in src/Form/Elements/ButtonElement.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          case 'warning': return 'btn-warning';
              Severity: Major
              Found in src/Form/Elements/ButtonElement.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            case 'success': return 'btn-success';
                Severity: Major
                Found in src/Form/Elements/ButtonElement.php - About 30 mins to fix

                  Function makeElement has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function makeElement(array $options, $html)
    {
        if (isset($options['type']) && $options['type'] == 'hidden') return $html;

        if (!empty($options['before-input'])) $html =  $options['before-input'].$html;
                  Severity: Minor
                  Found in src/Form/Elements/AbstractElement.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getOptionsForSelect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function getOptionsForSelect($options)
    {
        $currentValues = $this->getValue();
        $optionsHtml = '';
                  Severity: Minor
                  Found in src/Form/Elements/SelectElement.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language