firehol/netdata

View on GitHub

Showing 1,088 of 2,665 total issues

Method Manager.dyncfgConfigGet has 6 return statements (exceeds 4 allowed).
Open

func (m *Manager) dyncfgConfigGet(fn functions.Function) {
    id := fn.Args[0]
    mn, jn, ok := extractModuleJobName(id)
    if !ok {
        m.Warningf("dyncfg: get: could not extract module and job from id (%s)", id)
Severity: Major
Found in src/go/plugin/go.d/agent/jobmgr/dyncfg.go - About 40 mins to fix

    Method Rethinkdb.collectStats has 6 return statements (exceeds 4 allowed).
    Open

    func (r *Rethinkdb) collectStats(mx map[string]int64) error {
        resp, err := r.rdb.stats()
        if err != nil {
            return err
        }
    Severity: Major
    Found in src/go/plugin/go.d/modules/rethinkdb/collect.go - About 40 mins to fix

      Method NginxUnit.collect has 6 return statements (exceeds 4 allowed).
      Open

      func (n *NginxUnit) collect() (map[string]int64, error) {
          req, err := web.NewHTTPRequestWithPath(n.RequestConfig, urlPathStatus)
          if err != nil {
              return nil, fmt.Errorf("failed to create HTTP request to '%s': %v", n.URL, err)
          }
      Severity: Major
      Found in src/go/plugin/go.d/modules/nginxunit/collect.go - About 40 mins to fix

        Method smartctlCliExec.execute has 6 return statements (exceeds 4 allowed).
        Open

        func (e *smartctlCliExec) execute(args ...string) (*gjson.Result, error) {
            ctx, cancel := context.WithTimeout(context.Background(), e.timeout)
            defer cancel()
        
            cmd := exec.CommandContext(ctx, e.ndsudoPath, args...)
        Severity: Major
        Found in src/go/plugin/go.d/modules/smartctl/exec.go - About 40 mins to fix

          Method Discoverer.discover has 6 return statements (exceeds 4 allowed).
          Open

          func (d Discoverer) discover() (*resources, error) {
              d.Debug("discovering : starting resource discovering process")
          
              start := time.Now()
              t := start
          Severity: Major
          Found in src/go/plugin/go.d/modules/vsphere/discover/discover.go - About 40 mins to fix

            Method StorCli.collect has 6 return statements (exceeds 4 allowed).
            Open

            func (s *StorCli) collect() (map[string]int64, error) {
                cntrlResp, err := s.queryControllersInfo()
                if err != nil {
                    return nil, err
                }
            Severity: Major
            Found in src/go/plugin/go.d/modules/storcli/collect.go - About 40 mins to fix

              Method Mongo.collect has 6 return statements (exceeds 4 allowed).
              Open

              func (m *Mongo) collect() (map[string]int64, error) {
                  if err := m.conn.initClient(m.URI, m.Timeout.Duration()); err != nil {
                      return nil, fmt.Errorf("init mongo conn: %v", err)
                  }
              
              
              Severity: Major
              Found in src/go/plugin/go.d/modules/mongodb/collect.go - About 40 mins to fix

                Function parse has 6 return statements (exceeds 4 allowed).
                Open

                func parse(filename string, visited map[string]bool) ([]option, error) {
                    if visited == nil {
                        visited = make(map[string]bool)
                    }
                    if visited[filename] {
                Severity: Major
                Found in src/go/plugin/go.d/modules/unbound/config/parse.go - About 40 mins to fix

                  Function loadCookieJar has 6 return statements (exceeds 4 allowed).
                  Open

                  func loadCookieJar(path string) (http.CookieJar, error) {
                      file, err := os.Open(path)
                      if err != nil {
                          return nil, err
                      }
                  Severity: Major
                  Found in src/go/plugin/go.d/modules/httpcheck/cookiejar.go - About 40 mins to fix

                    Method AP.collect has 6 return statements (exceeds 4 allowed).
                    Open

                    func (a *AP) collect() (map[string]int64, error) {
                        bs, err := a.exec.devices()
                        if err != nil {
                            return nil, err
                        }
                    Severity: Major
                    Found in src/go/plugin/go.d/modules/ap/collect.go - About 40 mins to fix

                      Method Ceph.collect has 6 return statements (exceeds 4 allowed).
                      Open

                      func (c *Ceph) collect() (map[string]int64, error) {
                          mx := make(map[string]int64)
                      
                          if err := c.auth(); err != nil {
                              return nil, err
                      Severity: Major
                      Found in src/go/plugin/go.d/modules/ceph/collect.go - About 40 mins to fix

                        Method gearmanClient.query has 6 return statements (exceeds 4 allowed).
                        Open

                        func (c *gearmanClient) query(cmd string) ([]byte, error) {
                            const limitReadLines = 10000
                            var num int
                            var err error
                            var b bytes.Buffer
                        Severity: Major
                        Found in src/go/plugin/go.d/modules/gearman/client.go - About 40 mins to fix

                          Method StorCli.queryDrivesInfo has 6 return statements (exceeds 4 allowed).
                          Open

                          func (s *StorCli) queryDrivesInfo() (*drivesInfoResponse, error) {
                              bs, err := s.exec.drivesInfo()
                              if err != nil {
                                  return nil, err
                              }
                          Severity: Major
                          Found in src/go/plugin/go.d/modules/storcli/collect_drives.go - About 40 mins to fix

                            Method StorCli.queryControllersInfo has 6 return statements (exceeds 4 allowed).
                            Open

                            func (s *StorCli) queryControllersInfo() (*controllersInfoResponse, error) {
                                bs, err := s.exec.controllersInfo()
                                if err != nil {
                                    return nil, err
                                }
                            Severity: Major
                            Found in src/go/plugin/go.d/modules/storcli/collect_controllers.go - About 40 mins to fix

                              Method zookeeperFetcher.fetch has 6 return statements (exceeds 4 allowed).
                              Open

                              func (c *zookeeperFetcher) fetch(command string) (rows []string, err error) {
                                  if err = c.Connect(); err != nil {
                                      return nil, err
                                  }
                                  defer func() { _ = c.Disconnect() }()
                              Severity: Major
                              Found in src/go/plugin/go.d/modules/zookeeper/fetcher.go - About 40 mins to fix

                                Function newStatusServerPacket has 6 return statements (exceeds 4 allowed).
                                Open

                                func newStatusServerPacket(secret string) (*radius.Packet, error) {
                                    // https://wiki.freeradius.org/config/Status#status-of-freeradius-server
                                    packet := radius.New(radius.CodeStatusServer, []byte(secret))
                                    if err := FreeRADIUSStatisticsType_Set(packet, FreeRADIUSStatisticsType_Value_All); err != nil {
                                        return nil, err
                                Severity: Major
                                Found in src/go/plugin/go.d/modules/freeradius/api/client.go - About 40 mins to fix

                                  Method logLine.assignRequest has 6 return statements (exceeds 4 allowed).
                                  Open

                                  func (l *logLine) assignRequest(request string) error {
                                      if request == hyphen {
                                          return nil
                                      }
                                      var first, last int
                                  Severity: Major
                                  Found in src/go/plugin/go.d/modules/weblog/logline.go - About 40 mins to fix

                                    Function attributeUnit has 6 return statements (exceeds 4 allowed).
                                    Open

                                    func attributeUnit(attrName string) string {
                                        units := map[string]string{
                                            "Airflow_Temperature_Cel": "Celsius",
                                            "Case_Temperature":        "Celsius",
                                            "Drive_Temperature":       "Celsius",
                                    Severity: Major
                                    Found in src/go/plugin/go.d/modules/smartctl/charts.go - About 40 mins to fix

                                      Method Gearman.collect has 6 return statements (exceeds 4 allowed).
                                      Open

                                      func (g *Gearman) collect() (map[string]int64, error) {
                                          if g.conn == nil {
                                              conn, err := g.establishConn()
                                              if err != nil {
                                                  return nil, err
                                      Severity: Major
                                      Found in src/go/plugin/go.d/modules/gearman/collect.go - About 40 mins to fix

                                        Function parseSsacliControllersInfo has 6 return statements (exceeds 4 allowed).
                                        Open

                                        func parseSsacliControllersInfo(data []byte) (map[string]*hpssaController, error) {
                                            var (
                                                cntrl *hpssaController
                                                arr   *hpssaArray
                                                ld    *hpssaLogicalDrive
                                        Severity: Major
                                        Found in src/go/plugin/go.d/modules/hpssa/parse.go - About 40 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language