Sign upLogin

firehol/netdata

View on GitHub
Star
src/collectors/python.d.plugin/zscores/zscores.chart.py

Summary

Maintainability
A
1 hr
Test Coverage

Function create_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def create_data(self, df_allmetrics):
        """Use x, mean, stddev to generate z scores and 3stddev flags via some pandas manipulation.
        Returning two dictionaries of dimensions and measures, one for each chart.

        :param df_allmetrics <pd.DataFrame>: pandas dataframe with latest data from api/v1/allmetrics.
Severity: Minor
Found in src/collectors/python.d.plugin/zscores/zscores.chart.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_charts has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def validate_charts(self, chart, data, algorithm='absolute', multiplier=1, divisor=1):
Severity: Minor
Found in src/collectors/python.d.plugin/zscores/zscores.chart.py - About 35 mins to fix

    Function validate_charts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_charts(self, chart, data, algorithm='absolute', multiplier=1, divisor=1):
        """If dimension not in chart then add it.
        """
        for dim in data:
            if dim not in self.collected_dims[chart]:
    Severity: Minor
    Found in src/collectors/python.d.plugin/zscores/zscores.chart.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status