firehol/netdata

View on GitHub
src/go/plugin/go.d/modules/memcached/charts.go

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    netChart = module.Chart{
        ID:       "net",
        Title:    "Network",
        Units:    "kilobits/s",
        Fam:      "network",
Severity: Minor
Found in src/go/plugin/go.d/modules/memcached/charts.go and 1 other location - About 55 mins to fix
src/go/plugin/go.d/modules/redis/charts.go on lines 187..199

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    casChart = module.Chart{
        ID:       "cas",
        Title:    "Check and Set Requests",
        Units:    "requests",
        Fam:      "check and set ops",
Severity: Major
Found in src/go/plugin/go.d/modules/memcached/charts.go and 2 other locations - About 55 mins to fix
src/go/plugin/go.d/modules/memcached/charts.go on lines 74..87
src/go/plugin/go.d/modules/mysql/charts.go on lines 1080..1093

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 126.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    connectionsChart = module.Chart{
        ID:       "connections",
        Title:    "Connections",
        Units:    "connections/s",
        Fam:      "connections",
Severity: Major
Found in src/go/plugin/go.d/modules/memcached/charts.go and 2 other locations - About 55 mins to fix
src/go/plugin/go.d/modules/memcached/charts.go on lines 164..177
src/go/plugin/go.d/modules/mysql/charts.go on lines 1080..1093

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 126.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var charts = module.Charts{
    cacheChart.Copy(),
    netChart.Copy(),
    connectionsChart.Copy(),
    itemsChart.Copy(),
Severity: Minor
Found in src/go/plugin/go.d/modules/memcached/charts.go and 1 other location - About 40 mins to fix
src/go/plugin/go.d/modules/varnish/charts.go on lines 39..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    touchChart = module.Chart{
        ID:       "touch",
        Title:    "Touch Requests",
        Units:    "requests",
        Fam:      "touch ops",
Severity: Major
Found in src/go/plugin/go.d/modules/memcached/charts.go and 23 other locations - About 35 mins to fix
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 176..188
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 258..270
src/go/plugin/go.d/modules/dmcache/charts.go on lines 63..75
src/go/plugin/go.d/modules/dmcache/charts.go on lines 76..88
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 145..157
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 171..183
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 400..412
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 413..425
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 666..678
src/go/plugin/go.d/modules/memcached/charts.go on lines 114..126
src/go/plugin/go.d/modules/memcached/charts.go on lines 151..163
src/go/plugin/go.d/modules/memcached/charts.go on lines 178..190
src/go/plugin/go.d/modules/memcached/charts.go on lines 191..203
src/go/plugin/go.d/modules/mongodb/charts.go on lines 809..821
src/go/plugin/go.d/modules/mysql/charts.go on lines 1067..1079
src/go/plugin/go.d/modules/mysql/charts.go on lines 1105..1117
src/go/plugin/go.d/modules/rspamd/charts.go on lines 29..41
src/go/plugin/go.d/modules/smartctl/charts.go on lines 106..118
src/go/plugin/go.d/modules/smartctl/charts.go on lines 119..131
src/go/plugin/go.d/modules/smartctl/charts.go on lines 132..144
src/go/plugin/go.d/modules/varnish/charts.go on lines 72..84
src/go/plugin/go.d/modules/varnish/charts.go on lines 144..156
src/go/plugin/go.d/modules/varnish/charts.go on lines 237..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    decrementChart = module.Chart{
        ID:       "decrement",
        Title:    "Decrement Requests",
        Units:    "requests",
        Fam:      "decrement ops",
Severity: Major
Found in src/go/plugin/go.d/modules/memcached/charts.go and 23 other locations - About 35 mins to fix
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 176..188
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 258..270
src/go/plugin/go.d/modules/dmcache/charts.go on lines 63..75
src/go/plugin/go.d/modules/dmcache/charts.go on lines 76..88
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 145..157
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 171..183
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 400..412
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 413..425
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 666..678
src/go/plugin/go.d/modules/memcached/charts.go on lines 114..126
src/go/plugin/go.d/modules/memcached/charts.go on lines 151..163
src/go/plugin/go.d/modules/memcached/charts.go on lines 178..190
src/go/plugin/go.d/modules/memcached/charts.go on lines 204..216
src/go/plugin/go.d/modules/mongodb/charts.go on lines 809..821
src/go/plugin/go.d/modules/mysql/charts.go on lines 1067..1079
src/go/plugin/go.d/modules/mysql/charts.go on lines 1105..1117
src/go/plugin/go.d/modules/rspamd/charts.go on lines 29..41
src/go/plugin/go.d/modules/smartctl/charts.go on lines 106..118
src/go/plugin/go.d/modules/smartctl/charts.go on lines 119..131
src/go/plugin/go.d/modules/smartctl/charts.go on lines 132..144
src/go/plugin/go.d/modules/varnish/charts.go on lines 72..84
src/go/plugin/go.d/modules/varnish/charts.go on lines 144..156
src/go/plugin/go.d/modules/varnish/charts.go on lines 237..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    incrementChart = module.Chart{
        ID:       "increment",
        Title:    "Increment Requests",
        Units:    "requests",
        Fam:      "increment ops",
Severity: Major
Found in src/go/plugin/go.d/modules/memcached/charts.go and 23 other locations - About 35 mins to fix
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 176..188
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 258..270
src/go/plugin/go.d/modules/dmcache/charts.go on lines 63..75
src/go/plugin/go.d/modules/dmcache/charts.go on lines 76..88
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 145..157
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 171..183
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 400..412
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 413..425
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 666..678
src/go/plugin/go.d/modules/memcached/charts.go on lines 114..126
src/go/plugin/go.d/modules/memcached/charts.go on lines 151..163
src/go/plugin/go.d/modules/memcached/charts.go on lines 191..203
src/go/plugin/go.d/modules/memcached/charts.go on lines 204..216
src/go/plugin/go.d/modules/mongodb/charts.go on lines 809..821
src/go/plugin/go.d/modules/mysql/charts.go on lines 1067..1079
src/go/plugin/go.d/modules/mysql/charts.go on lines 1105..1117
src/go/plugin/go.d/modules/rspamd/charts.go on lines 29..41
src/go/plugin/go.d/modules/smartctl/charts.go on lines 106..118
src/go/plugin/go.d/modules/smartctl/charts.go on lines 119..131
src/go/plugin/go.d/modules/smartctl/charts.go on lines 132..144
src/go/plugin/go.d/modules/varnish/charts.go on lines 72..84
src/go/plugin/go.d/modules/varnish/charts.go on lines 144..156
src/go/plugin/go.d/modules/varnish/charts.go on lines 237..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    getChart = module.Chart{
        ID:       "get",
        Title:    "Get Requests",
        Units:    "requests",
        Fam:      "get ops",
Severity: Major
Found in src/go/plugin/go.d/modules/memcached/charts.go and 23 other locations - About 35 mins to fix
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 176..188
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 258..270
src/go/plugin/go.d/modules/dmcache/charts.go on lines 63..75
src/go/plugin/go.d/modules/dmcache/charts.go on lines 76..88
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 145..157
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 171..183
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 400..412
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 413..425
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 666..678
src/go/plugin/go.d/modules/memcached/charts.go on lines 151..163
src/go/plugin/go.d/modules/memcached/charts.go on lines 178..190
src/go/plugin/go.d/modules/memcached/charts.go on lines 191..203
src/go/plugin/go.d/modules/memcached/charts.go on lines 204..216
src/go/plugin/go.d/modules/mongodb/charts.go on lines 809..821
src/go/plugin/go.d/modules/mysql/charts.go on lines 1067..1079
src/go/plugin/go.d/modules/mysql/charts.go on lines 1105..1117
src/go/plugin/go.d/modules/rspamd/charts.go on lines 29..41
src/go/plugin/go.d/modules/smartctl/charts.go on lines 106..118
src/go/plugin/go.d/modules/smartctl/charts.go on lines 119..131
src/go/plugin/go.d/modules/smartctl/charts.go on lines 132..144
src/go/plugin/go.d/modules/varnish/charts.go on lines 72..84
src/go/plugin/go.d/modules/varnish/charts.go on lines 144..156
src/go/plugin/go.d/modules/varnish/charts.go on lines 237..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    deleteChart = module.Chart{
        ID:       "delete",
        Title:    "Delete Requests",
        Units:    "requests",
        Fam:      "delete ops",
Severity: Major
Found in src/go/plugin/go.d/modules/memcached/charts.go and 23 other locations - About 35 mins to fix
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 176..188
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 258..270
src/go/plugin/go.d/modules/dmcache/charts.go on lines 63..75
src/go/plugin/go.d/modules/dmcache/charts.go on lines 76..88
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 145..157
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 171..183
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 400..412
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 413..425
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 666..678
src/go/plugin/go.d/modules/memcached/charts.go on lines 114..126
src/go/plugin/go.d/modules/memcached/charts.go on lines 178..190
src/go/plugin/go.d/modules/memcached/charts.go on lines 191..203
src/go/plugin/go.d/modules/memcached/charts.go on lines 204..216
src/go/plugin/go.d/modules/mongodb/charts.go on lines 809..821
src/go/plugin/go.d/modules/mysql/charts.go on lines 1067..1079
src/go/plugin/go.d/modules/mysql/charts.go on lines 1105..1117
src/go/plugin/go.d/modules/rspamd/charts.go on lines 29..41
src/go/plugin/go.d/modules/smartctl/charts.go on lines 106..118
src/go/plugin/go.d/modules/smartctl/charts.go on lines 119..131
src/go/plugin/go.d/modules/smartctl/charts.go on lines 132..144
src/go/plugin/go.d/modules/varnish/charts.go on lines 72..84
src/go/plugin/go.d/modules/varnish/charts.go on lines 144..156
src/go/plugin/go.d/modules/varnish/charts.go on lines 237..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status