firehol/netdata

Method socketClient.getStatus has 7 return statements (exceeds 4 allowed).

Open

func (c *socketClient) getStatus() (*status, error) {
    socket, err := fcgiclient.DialTimeout("unix", c.socket, c.timeout)
    if err != nil {
        return nil, fmt.Errorf("error on connecting to socket '%s': %v", c.socket, err)
    }

Method tcpClient.getStatus has 6 return statements (exceeds 4 allowed).

Open

func (c *tcpClient) getStatus() (*status, error) {
    client, err := fcgiclient.DialTimeout("tcp", c.address, c.timeout)
    if err != nil {
        return nil, fmt.Errorf("error on connecting to address '%s': %v", c.address, err)
    }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func newSocketClient(log *logger.Logger, socket string, timeout time.Duration, fcgiPath string) *socketClient {
    return &socketClient{
        Logger:  log,
        socket:  socket,
        timeout: timeout,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func newTcpClient(log *logger.Logger, address string, timeout time.Duration, fcgiPath string) *tcpClient {
    return &tcpClient{
        Logger:  log,
        address: address,
        timeout: timeout,

• Read up
  Read up