firehol/netdata

View on GitHub
src/go/plugin/go.d/modules/sensors/lmsensors/scanner.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Scanner.Scan has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func (sc *Scanner) Scan() ([]*Device, error) {
    paths, err := sc.detectDevicePaths()
    if err != nil {
        return nil, err
    }
Severity: Minor
Found in src/go/plugin/go.d/modules/sensors/lmsensors/scanner.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Scanner.Scan has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (sc *Scanner) Scan() ([]*Device, error) {
    paths, err := sc.detectDevicePaths()
    if err != nil {
        return nil, err
    }
Severity: Minor
Found in src/go/plugin/go.d/modules/sensors/lmsensors/scanner.go - About 1 hr to fix

    Method Scanner.detectDevicePaths has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
    Open

    func (sc *Scanner) detectDevicePaths() ([]string, error) {
        const lookPath = "/sys/class/hwmon"
    
        var paths []string
        err := sc.fs.WalkDir(lookPath, func(path string, de os.DirEntry, err error) error {
    Severity: Minor
    Found in src/go/plugin/go.d/modules/sensors/lmsensors/scanner.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Scanner.detectDevicePaths has 13 return statements (exceeds 4 allowed).
    Open

    func (sc *Scanner) detectDevicePaths() ([]string, error) {
        const lookPath = "/sys/class/hwmon"
    
        var paths []string
        err := sc.fs.WalkDir(lookPath, func(path string, de os.DirEntry, err error) error {
    Severity: Major
    Found in src/go/plugin/go.d/modules/sensors/lmsensors/scanner.go - About 1 hr to fix

      Method Scanner.Scan has 12 return statements (exceeds 4 allowed).
      Open

      func (sc *Scanner) Scan() ([]*Device, error) {
          paths, err := sc.detectDevicePaths()
          if err != nil {
              return nil, err
          }
      Severity: Major
      Found in src/go/plugin/go.d/modules/sensors/lmsensors/scanner.go - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status