Sign upLogin

firehol/netdata

View on GitHub
Star
src/go/plugin/go.d/modules/varnish/charts.go

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (v *Varnish) addBackendCharts(fullName string) {
    charts := backendChartsTmpl.Copy()

    for _, chart := range *charts {
        chart.ID = cleanChartID(fmt.Sprintf(chart.ID, fullName))
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 1 other location - About 1 hr to fix
src/go/plugin/go.d/modules/varnish/charts.go on lines 346..363

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (v *Varnish) addStorageCharts(name string) {
    charts := storageChartsTmpl.Copy()

    for _, chart := range *charts {
        chart.ID = cleanChartID(fmt.Sprintf(chart.ID, name))
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 1 other location - About 1 hr to fix
src/go/plugin/go.d/modules/varnish/charts.go on lines 327..344

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 184.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var (
    storageSpaceUsageChartTmpl = module.Chart{
        ID:       "storage_%s_usage",
        Title:    "Storage Space Usage",
        Fam:      "storage usage",
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 1 other location - About 1 hr to fix
src/go/plugin/go.d/modules/hpssa/charts.go on lines 164..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 164.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        Dims: module.Dims{
            {ID: "MAIN.backend_conn", Name: "successful", Algo: module.Incremental},
            {ID: "MAIN.backend_unhealthy", Name: "unhealthy", Algo: module.Incremental},
            {ID: "MAIN.backend_busy", Name: "busy", Algo: module.Incremental},
            {ID: "MAIN.backend_fail", Name: "failed", Algo: module.Incremental},
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 1 other location - About 1 hr to fix
src/go/plugin/go.d/modules/envoy/charts.go on lines 403..411

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 159.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    cacheHitRatioTotalChart = module.Chart{
        ID:       "cache_hit_ratio_total",
        Title:    "Cache Hit Ratio Total",
        Fam:      "cache activity",
        Units:    "percent",
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 3 other locations - About 1 hr to fix
src/go/plugin/go.d/modules/mongodb/charts.go on lines 191..205
src/go/plugin/go.d/modules/varnish/charts.go on lines 117..131
src/go/plugin/go.d/modules/varnish/charts.go on lines 173..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    cacheHitRatioDeltaChart = module.Chart{
        ID:       "cache_hit_ratio_delta",
        Title:    "Cache Hit Ratio Current Poll",
        Fam:      "cache activity",
        Units:    "percent",
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 3 other locations - About 1 hr to fix
src/go/plugin/go.d/modules/mongodb/charts.go on lines 191..205
src/go/plugin/go.d/modules/varnish/charts.go on lines 102..116
src/go/plugin/go.d/modules/varnish/charts.go on lines 173..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    threadManagementActivityChart = module.Chart{
        ID:       "thread_management_activity",
        Title:    "Thread Management Activity",
        Fam:      "threads",
        Units:    "threads/s",
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 3 other locations - About 1 hr to fix
src/go/plugin/go.d/modules/mongodb/charts.go on lines 191..205
src/go/plugin/go.d/modules/varnish/charts.go on lines 102..116
src/go/plugin/go.d/modules/varnish/charts.go on lines 117..131

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var varnishCharts = module.Charts{
    clientSessionConnectionsChart.Copy(),
    clientRequestsChart.Copy(),

    backendConnectionsChart.Copy(),
Severity: Minor
Found in src/go/plugin/go.d/modules/varnish/charts.go and 1 other location - About 40 mins to fix
src/go/plugin/go.d/modules/memcached/charts.go on lines 26..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    cacheLRUActivityChart = module.Chart{
        ID:       "cache_lru_activity",
        Title:    "Cache LRU Activity",
        Fam:      "cache activity",
        Units:    "objects/s",
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 23 other locations - About 35 mins to fix
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 176..188
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 258..270
src/go/plugin/go.d/modules/dmcache/charts.go on lines 63..75
src/go/plugin/go.d/modules/dmcache/charts.go on lines 76..88
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 145..157
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 171..183
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 400..412
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 413..425
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 666..678
src/go/plugin/go.d/modules/memcached/charts.go on lines 114..126
src/go/plugin/go.d/modules/memcached/charts.go on lines 151..163
src/go/plugin/go.d/modules/memcached/charts.go on lines 178..190
src/go/plugin/go.d/modules/memcached/charts.go on lines 191..203
src/go/plugin/go.d/modules/memcached/charts.go on lines 204..216
src/go/plugin/go.d/modules/mongodb/charts.go on lines 809..821
src/go/plugin/go.d/modules/mysql/charts.go on lines 1067..1079
src/go/plugin/go.d/modules/mysql/charts.go on lines 1105..1117
src/go/plugin/go.d/modules/rspamd/charts.go on lines 29..41
src/go/plugin/go.d/modules/smartctl/charts.go on lines 106..118
src/go/plugin/go.d/modules/smartctl/charts.go on lines 119..131
src/go/plugin/go.d/modules/smartctl/charts.go on lines 132..144
src/go/plugin/go.d/modules/varnish/charts.go on lines 72..84
src/go/plugin/go.d/modules/varnish/charts.go on lines 237..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    esiParsingIssuesChart = module.Chart{
        ID:       "esi_parsing_issues",
        Title:    "ESI Parsing Issues",
        Fam:      "esi",
        Units:    "issues/s",
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 23 other locations - About 35 mins to fix
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 176..188
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 258..270
src/go/plugin/go.d/modules/dmcache/charts.go on lines 63..75
src/go/plugin/go.d/modules/dmcache/charts.go on lines 76..88
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 145..157
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 171..183
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 400..412
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 413..425
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 666..678
src/go/plugin/go.d/modules/memcached/charts.go on lines 114..126
src/go/plugin/go.d/modules/memcached/charts.go on lines 151..163
src/go/plugin/go.d/modules/memcached/charts.go on lines 178..190
src/go/plugin/go.d/modules/memcached/charts.go on lines 191..203
src/go/plugin/go.d/modules/memcached/charts.go on lines 204..216
src/go/plugin/go.d/modules/mongodb/charts.go on lines 809..821
src/go/plugin/go.d/modules/mysql/charts.go on lines 1067..1079
src/go/plugin/go.d/modules/mysql/charts.go on lines 1105..1117
src/go/plugin/go.d/modules/rspamd/charts.go on lines 29..41
src/go/plugin/go.d/modules/smartctl/charts.go on lines 106..118
src/go/plugin/go.d/modules/smartctl/charts.go on lines 119..131
src/go/plugin/go.d/modules/smartctl/charts.go on lines 132..144
src/go/plugin/go.d/modules/varnish/charts.go on lines 72..84
src/go/plugin/go.d/modules/varnish/charts.go on lines 144..156

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    clientSessionConnectionsChart = module.Chart{
        ID:       "client_session_connections",
        Title:    "Client Session Connections",
        Fam:      "client connections",
        Units:    "connections/s",
Severity: Major
Found in src/go/plugin/go.d/modules/varnish/charts.go and 23 other locations - About 35 mins to fix
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 176..188
src/go/plugin/go.d/modules/beanstalk/charts.go on lines 258..270
src/go/plugin/go.d/modules/dmcache/charts.go on lines 63..75
src/go/plugin/go.d/modules/dmcache/charts.go on lines 76..88
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 145..157
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 171..183
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 400..412
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 413..425
src/go/plugin/go.d/modules/elasticsearch/charts.go on lines 666..678
src/go/plugin/go.d/modules/memcached/charts.go on lines 114..126
src/go/plugin/go.d/modules/memcached/charts.go on lines 151..163
src/go/plugin/go.d/modules/memcached/charts.go on lines 178..190
src/go/plugin/go.d/modules/memcached/charts.go on lines 191..203
src/go/plugin/go.d/modules/memcached/charts.go on lines 204..216
src/go/plugin/go.d/modules/mongodb/charts.go on lines 809..821
src/go/plugin/go.d/modules/mysql/charts.go on lines 1067..1079
src/go/plugin/go.d/modules/mysql/charts.go on lines 1105..1117
src/go/plugin/go.d/modules/rspamd/charts.go on lines 29..41
src/go/plugin/go.d/modules/smartctl/charts.go on lines 106..118
src/go/plugin/go.d/modules/smartctl/charts.go on lines 119..131
src/go/plugin/go.d/modules/smartctl/charts.go on lines 132..144
src/go/plugin/go.d/modules/varnish/charts.go on lines 144..156
src/go/plugin/go.d/modules/varnish/charts.go on lines 237..249

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status