firehoseio/firehose

View on GitHub

Showing 65 of 65 total issues

Method put has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

        def put(message, channel, opts, &block)
          ttl         = opts[:ttl]
          timeout     = opts[:timeout] || @timeout || DEFAULT_TIMEOUT
          buffer_size = opts[:buffer_size]
          deprecated  = opts[:deprecated]
Severity: Minor
Found in lib/firehose/client/producer.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for put is too high. [14/6]
Open

        def put(message, channel, opts, &block)
          ttl         = opts[:ttl]
          timeout     = opts[:timeout] || @timeout || DEFAULT_TIMEOUT
          buffer_size = opts[:buffer_size]
          deprecated  = opts[:deprecated]
Severity: Minor
Found in lib/firehose/client/producer.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [38/30]
Open

      def publish(channel_key, message, opts={})
        # How long should we hang on to the resource once is published?
        ttl = (opts[:ttl] || TTL).to_i
        buffer_size = (opts[:buffer_size] || MessageBuffer::DEFAULT_SIZE).to_i
        persist = !!opts[:persist]
Severity: Minor
Found in lib/firehose/server/publisher.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [35/30]
Open

          def respond_async(channel, last_sequence, params, env)
            EM.next_tick do
              if last_sequence < 0
                async_callback env, 400, "The last_message_sequence parameter may not be less than zero"
              else

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [34/30]
Open

        def put(message, channel, opts, &block)
          ttl         = opts[:ttl]
          timeout     = opts[:timeout] || @timeout || DEFAULT_TIMEOUT
          buffer_size = opts[:buffer_size]
          deprecated  = opts[:deprecated]
Severity: Minor
Found in lib/firehose/client/producer.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for publish is too high. [8/6]
Open

      def publish(channel_key, message, opts={})
        # How long should we hang on to the resource once is published?
        ttl = (opts[:ttl] || TTL).to_i
        buffer_size = (opts[:buffer_size] || MessageBuffer::DEFAULT_SIZE).to_i
        persist = !!opts[:persist]
Severity: Minor
Found in lib/firehose/server/publisher.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method publish has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def publish(uri, payload=nil)
      payload     ||= $stdin.read
      client      = Firehose::Client::Producer::Http.new(uri)
      path        = ::URI.parse(uri).path
      times       = options[:times]
Severity: Minor
Found in lib/firehose/cli.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method publish has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def publish(channel_key, message, opts={})
        # How long should we hang on to the resource once is published?
        ttl = (opts[:ttl] || TTL).to_i
        buffer_size = (opts[:buffer_size] || MessageBuffer::DEFAULT_SIZE).to_i
        persist = !!opts[:persist]
Severity: Minor
Found in lib/firehose/server/publisher.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method publish has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def publish(channel_key, message, opts={})
        # How long should we hang on to the resource once is published?
        ttl = (opts[:ttl] || TTL).to_i
        buffer_size = (opts[:buffer_size] || MessageBuffer::DEFAULT_SIZE).to_i
        persist = !!opts[:persist]
Severity: Minor
Found in lib/firehose/server/publisher.rb - About 1 hr to fix

    Method respond_async has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              def respond_async(channel, last_sequence, params, env)
                EM.next_tick do
                  if last_sequence < 0
                    async_callback env, 400, "The last_message_sequence parameter may not be less than zero"
                  else
    Severity: Minor
    Found in lib/firehose/rack/consumer/http_long_poll.rb - About 1 hr to fix

      Method put has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def put(message, channel, opts, &block)
                ttl         = opts[:ttl]
                timeout     = opts[:timeout] || @timeout || DEFAULT_TIMEOUT
                buffer_size = opts[:buffer_size]
                deprecated  = opts[:deprecated]
      Severity: Minor
      Found in lib/firehose/client/producer.rb - About 1 hr to fix

        Method respond_async has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

                  def respond_async(channel, last_sequence, params, env)
                    EM.next_tick do
                      if last_sequence < 0
                        async_callback env, 400, "The last_message_sequence parameter may not be less than zero"
                      else
        Severity: Minor
        Found in lib/firehose/rack/consumer/http_long_poll.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method call has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def call(env)
                req           = env['parsed_request'] ||= ::Rack::Request.new(env)
                path          = req.path
                method        = req.request_method
                cache_control = {}
        Severity: Minor
        Found in lib/firehose/rack/publisher.rb - About 1 hr to fix

          Method subscribe has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                    def subscribe(channel_name, last_sequence, params)
                      chan_sub = Server::ChannelSubscription.new(
                        channel_name,
                        @ws.env,
                        params: params,
          Severity: Minor
          Found in lib/firehose/rack/consumer/web_socket.rb - About 1 hr to fix

            Method eval_publish_script has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def eval_publish_script(channel_key, message, ttl, buffer_size, persist, deferrable)
            Severity: Minor
            Found in lib/firehose/server/publisher.rb - About 45 mins to fix

              Method post_subscriptions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                    def self.post_subscriptions(request)
                      body = request.body.read
                      subs = JSON.parse(body).map do |chan, val|
                        # Hash is the newer format subscription message that supports
                        # params
              Severity: Minor
              Found in lib/firehose/rack/consumer.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid parameter lists longer than 5 parameters. [6/5]
              Open

                    def eval_publish_script(channel_key, message, ttl, buffer_size, persist, deferrable)
              Severity: Minor
              Found in lib/firehose/server/publisher.rb by rubocop

              This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

              Method message has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                        def message(event)
                          msg = parse_message(event)
              
                          if subscriptions = msg[:multiplex_subscribe]
                            subscriptions = [subscriptions] unless subscriptions.is_a?(Array)
              Severity: Minor
              Found in lib/firehose/rack/consumer/web_socket.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method subscribe_multiplexed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                        def subscribe_multiplexed(subscriptions)
                          channels = subscriptions.map{|s| s[:channel]}
                          Firehose::Server.metrics.channels_subscribed_multiplexed_ws!(channels)
              
                          subscriptions.each do |sub|
              Severity: Minor
              Found in lib/firehose/rack/consumer/web_socket.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def call(env)
                      # Cache the parsed request so we don't need to re-parse it when we pass
                      # control onto another app.
                      req     = env['parsed_request'] ||= ::Rack::Request.new(env)
                      method  = req.request_method
              Severity: Minor
              Found in lib/firehose/rack/app.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language