Sign upLogin

fisharebest/webtrees

View on GitHub
Star
app/Elements/NoteStructure.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method labelValue has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function labelValue(string $value, Tree $tree): string
    {
        $id       = Registry::idFactory()->id();
        $expanded = $tree->getPreference('EXPAND_NOTES') === '1';
Severity: Minor
Found in app/Elements/NoteStructure.php - About 2 hrs to fix

    Method edit has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function edit(string $id, string $name, string $value, Tree $tree): string
    {
        $submitter_text = new SubmitterText('');
        $xref_note      = new XrefNote('');
    Severity: Minor
    Found in app/Elements/NoteStructure.php - About 1 hr to fix

      Function labelValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function labelValue(string $value, Tree $tree): string
    {
        $id       = Registry::idFactory()->id();
        $expanded = $tree->getPreference('EXPAND_NOTES') === '1';
      Severity: Minor
      Found in app/Elements/NoteStructure.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return '<div>' . I18N::translate('%1$s: %2$s', $label, $value) . '</div>';
      Severity: Major
      Found in app/Elements/NoteStructure.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return
            '<div class="wt-text-overflow-elipsis">' .
            '<button type="button" class="btn btn-text p-0" href="#" data-bs-target=".' . e($id) . '" data-bs-toggle="collapse" aria-controls="' . e($id) . '" aria-expanded="' . ($expanded ? 'true' : 'false') . '">' .
            view('icons/expand') .
            view('icons/collapse') .
        Severity: Major
        Found in app/Elements/NoteStructure.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status