fisharebest/webtrees

View on GitHub
app/Http/RequestHandlers/CheckTree.php

Summary

Maintainability
F
5 days
Test Coverage

Function handle has a Cognitive Complexity of 84 (exceeds 5 allowed). Consider refactoring.
Open

Severity: Minor
Found in app/Http/RequestHandlers/CheckTree.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle has 207 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Severity: Major
Found in app/Http/RequestHandlers/CheckTree.php - About 1 day to fix

    Consider simplifying this complex logical expression.
    Open

    Severity: Critical
    Found in app/Http/RequestHandlers/CheckTree.php - About 4 hrs to fix

      File CheckTree.php has 329 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      Severity: Minor
      Found in app/Http/RequestHandlers/CheckTree.php - About 3 hrs to fix

        Method lineError has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        Severity: Major
        Found in app/Http/RequestHandlers/CheckTree.php - About 50 mins to fix

          Method recordError has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          Severity: Minor
          Found in app/Http/RequestHandlers/CheckTree.php - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 1 other location - About 2 hrs to fix
            app/Http/RequestHandlers/CheckTree.php on lines 262..267

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 133.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 1 other location - About 2 hrs to fix
            app/Http/RequestHandlers/CheckTree.php on lines 267..272

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 133.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 9 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 8 other locations - About 30 mins to fix
            app/Http/RequestHandlers/CheckTree.php on lines 233..236
            app/Http/RequestHandlers/CheckTree.php on lines 236..239
            app/Http/RequestHandlers/CheckTree.php on lines 239..242
            app/Http/RequestHandlers/CheckTree.php on lines 242..245
            app/Http/RequestHandlers/CheckTree.php on lines 245..248
            app/Http/RequestHandlers/CheckTree.php on lines 248..251
            app/Http/RequestHandlers/CheckTree.php on lines 251..254
            app/Http/RequestHandlers/CheckTree.php on lines 254..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 9 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 8 other locations - About 30 mins to fix
            app/Http/RequestHandlers/CheckTree.php on lines 230..233
            app/Http/RequestHandlers/CheckTree.php on lines 233..236
            app/Http/RequestHandlers/CheckTree.php on lines 236..239
            app/Http/RequestHandlers/CheckTree.php on lines 239..242
            app/Http/RequestHandlers/CheckTree.php on lines 242..245
            app/Http/RequestHandlers/CheckTree.php on lines 248..251
            app/Http/RequestHandlers/CheckTree.php on lines 251..254
            app/Http/RequestHandlers/CheckTree.php on lines 254..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 9 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 8 other locations - About 30 mins to fix
            app/Http/RequestHandlers/CheckTree.php on lines 230..233
            app/Http/RequestHandlers/CheckTree.php on lines 233..236
            app/Http/RequestHandlers/CheckTree.php on lines 239..242
            app/Http/RequestHandlers/CheckTree.php on lines 242..245
            app/Http/RequestHandlers/CheckTree.php on lines 245..248
            app/Http/RequestHandlers/CheckTree.php on lines 248..251
            app/Http/RequestHandlers/CheckTree.php on lines 251..254
            app/Http/RequestHandlers/CheckTree.php on lines 254..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 9 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 8 other locations - About 30 mins to fix
            app/Http/RequestHandlers/CheckTree.php on lines 230..233
            app/Http/RequestHandlers/CheckTree.php on lines 233..236
            app/Http/RequestHandlers/CheckTree.php on lines 236..239
            app/Http/RequestHandlers/CheckTree.php on lines 239..242
            app/Http/RequestHandlers/CheckTree.php on lines 245..248
            app/Http/RequestHandlers/CheckTree.php on lines 248..251
            app/Http/RequestHandlers/CheckTree.php on lines 251..254
            app/Http/RequestHandlers/CheckTree.php on lines 254..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 9 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 8 other locations - About 30 mins to fix
            app/Http/RequestHandlers/CheckTree.php on lines 230..233
            app/Http/RequestHandlers/CheckTree.php on lines 233..236
            app/Http/RequestHandlers/CheckTree.php on lines 236..239
            app/Http/RequestHandlers/CheckTree.php on lines 239..242
            app/Http/RequestHandlers/CheckTree.php on lines 242..245
            app/Http/RequestHandlers/CheckTree.php on lines 245..248
            app/Http/RequestHandlers/CheckTree.php on lines 251..254
            app/Http/RequestHandlers/CheckTree.php on lines 254..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 9 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 8 other locations - About 30 mins to fix
            app/Http/RequestHandlers/CheckTree.php on lines 230..233
            app/Http/RequestHandlers/CheckTree.php on lines 233..236
            app/Http/RequestHandlers/CheckTree.php on lines 236..239
            app/Http/RequestHandlers/CheckTree.php on lines 239..242
            app/Http/RequestHandlers/CheckTree.php on lines 242..245
            app/Http/RequestHandlers/CheckTree.php on lines 245..248
            app/Http/RequestHandlers/CheckTree.php on lines 248..251
            app/Http/RequestHandlers/CheckTree.php on lines 251..254

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 9 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 8 other locations - About 30 mins to fix
            app/Http/RequestHandlers/CheckTree.php on lines 230..233
            app/Http/RequestHandlers/CheckTree.php on lines 233..236
            app/Http/RequestHandlers/CheckTree.php on lines 236..239
            app/Http/RequestHandlers/CheckTree.php on lines 239..242
            app/Http/RequestHandlers/CheckTree.php on lines 242..245
            app/Http/RequestHandlers/CheckTree.php on lines 245..248
            app/Http/RequestHandlers/CheckTree.php on lines 248..251
            app/Http/RequestHandlers/CheckTree.php on lines 254..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 9 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 8 other locations - About 30 mins to fix
            app/Http/RequestHandlers/CheckTree.php on lines 230..233
            app/Http/RequestHandlers/CheckTree.php on lines 236..239
            app/Http/RequestHandlers/CheckTree.php on lines 239..242
            app/Http/RequestHandlers/CheckTree.php on lines 242..245
            app/Http/RequestHandlers/CheckTree.php on lines 245..248
            app/Http/RequestHandlers/CheckTree.php on lines 248..251
            app/Http/RequestHandlers/CheckTree.php on lines 251..254
            app/Http/RequestHandlers/CheckTree.php on lines 254..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 9 locations. Consider refactoring.
            Open

            Severity: Major
            Found in app/Http/RequestHandlers/CheckTree.php and 8 other locations - About 30 mins to fix
            app/Http/RequestHandlers/CheckTree.php on lines 230..233
            app/Http/RequestHandlers/CheckTree.php on lines 233..236
            app/Http/RequestHandlers/CheckTree.php on lines 236..239
            app/Http/RequestHandlers/CheckTree.php on lines 242..245
            app/Http/RequestHandlers/CheckTree.php on lines 245..248
            app/Http/RequestHandlers/CheckTree.php on lines 248..251
            app/Http/RequestHandlers/CheckTree.php on lines 251..254
            app/Http/RequestHandlers/CheckTree.php on lines 254..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status