Sign upLogin

fisharebest/webtrees

View on GitHub
Star
app/Module/MediaListModule.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method handle has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle(ServerRequestInterface $request): ResponseInterface
    {
        $tree = Validator::attributes($request)->tree();
        $user = Validator::attributes($request)->user();
Severity: Minor
Found in app/Module/MediaListModule.php - About 2 hrs to fix

    Method allMedia has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function allMedia(Tree $tree, string $folder, bool $subfolders, string $sort, string $filter, string $format): Collection
    {
        $query = DB::table('media')
            ->join('media_file', static function (JoinClause $join): void {
                $join
    Severity: Minor
    Found in app/Module/MediaListModule.php - About 1 hr to fix

      Function allMedia has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          private function allMedia(Tree $tree, string $folder, bool $subfolders, string $sort, string $filter, string $format): Collection
    {
        $query = DB::table('media')
            ->join('media_file', static function (JoinClause $join): void {
                $join
      Severity: Minor
      Found in app/Module/MediaListModule.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method allMedia has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private function allMedia(Tree $tree, string $folder, bool $subfolders, string $sort, string $filter, string $format): Collection
      Severity: Minor
      Found in app/Module/MediaListModule.php - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status