fisharebest/webtrees

View on GitHub
app/Module/RecentChangesModule.php

Summary

Maintainability
C
1 day
Test Coverage

Method getBlock has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getBlock(Tree $tree, int $block_id, string $context, array $config = []): string
    {
        $days      = (int) $this->getBlockSetting($block_id, 'days', self::DEFAULT_DAYS);
        $infoStyle = $this->getBlockSetting($block_id, 'infoStyle', self::DEFAULT_INFO_STYLE);
        $sortStyle = $this->getBlockSetting($block_id, 'sortStyle', self::DEFAULT_SORT_STYLE);
Severity: Major
Found in app/Module/RecentChangesModule.php - About 2 hrs to fix

    Method getRecentChangesFromGenealogy has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getRecentChangesFromGenealogy(Tree $tree, int $days): Collection
        {
            $julian_day = Registry::timestampFactory()->now()->subtractDays($days)->julianDay();
    
            $individuals = DB::table('dates')
    Severity: Minor
    Found in app/Module/RecentChangesModule.php - About 1 hr to fix

      Method editBlockConfiguration has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function editBlockConfiguration(Tree $tree, int $block_id): string
          {
              $days      = (int) $this->getBlockSetting($block_id, 'days', self::DEFAULT_DAYS);
              $infoStyle = $this->getBlockSetting($block_id, 'infoStyle', self::DEFAULT_INFO_STYLE);
              $sortStyle = $this->getBlockSetting($block_id, 'sortStyle', self::DEFAULT_SORT_STYLE);
      Severity: Minor
      Found in app/Module/RecentChangesModule.php - About 1 hr to fix

        Function getBlock has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getBlock(Tree $tree, int $block_id, string $context, array $config = []): string
            {
                $days      = (int) $this->getBlockSetting($block_id, 'days', self::DEFAULT_DAYS);
                $infoStyle = $this->getBlockSetting($block_id, 'infoStyle', self::DEFAULT_INFO_STYLE);
                $sortStyle = $this->getBlockSetting($block_id, 'sortStyle', self::DEFAULT_SORT_STYLE);
        Severity: Minor
        Found in app/Module/RecentChangesModule.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return $content;
        Severity: Major
        Found in app/Module/RecentChangesModule.php - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $individuals = DB::table('dates')
                      ->where('d_file', '=', $tree->id())
                      ->where('d_julianday1', '>=', $julian_day)
                      ->where('d_fact', '=', 'CHAN')
                      ->join('individuals', static function (JoinClause $join): void {
          Severity: Major
          Found in app/Module/RecentChangesModule.php and 1 other location - About 2 hrs to fix
          app/Module/RecentChangesModule.php on lines 358..370

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 139.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  $families = DB::table('dates')
                      ->where('d_file', '=', $tree->id())
                      ->where('d_julianday1', '>=', $julian_day)
                      ->where('d_fact', '=', 'CHAN')
                      ->join('families', static function (JoinClause $join): void {
          Severity: Major
          Found in app/Module/RecentChangesModule.php and 1 other location - About 2 hrs to fix
          app/Module/RecentChangesModule.php on lines 344..356

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 139.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status