fisharebest/webtrees

View on GitHub
app/Module/StatisticsChartModule.php

Summary

Maintainability
F
2 wks
Test Coverage

Function postCustomChartAction has a Cognitive Complexity of 144 (exceeds 5 allowed). Consider refactoring.
Open

    public function postCustomChartAction(ServerRequestInterface $request): ResponseInterface
    {
        $statistics = app(Statistics::class);
        assert($statistics instanceof Statistics);

Severity: Minor
Found in app/Module/StatisticsChartModule.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method postCustomChartAction has 470 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function postCustomChartAction(ServerRequestInterface $request): ResponseInterface
    {
        $statistics = app(Statistics::class);
        assert($statistics instanceof Statistics);

Severity: Major
Found in app/Module/StatisticsChartModule.php - About 2 days to fix

    File StatisticsChartModule.php has 780 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     * webtrees: online genealogy
     * Copyright (C) 2022 webtrees development team
    Severity: Major
    Found in app/Module/StatisticsChartModule.php - About 1 day to fix

      Method myPlot has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function myPlot(
              string $chart_title,
              array $x_axis,
              string $x_axis_title,
              array $ydata,
      Severity: Major
      Found in app/Module/StatisticsChartModule.php - About 2 hrs to fix

        Function findAxisEntry has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private function findAxisEntry($value, array $axis)
            {
                if (is_numeric($value)) {
                    $value = (int) $value;
        
        
        Severity: Minor
        Found in app/Module/StatisticsChartModule.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getChartAction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getChartAction(ServerRequestInterface $request): ResponseInterface
            {
                $tree = Validator::attributes($request)->tree();
                $user = Validator::attributes($request)->user();
        
        
        Severity: Minor
        Found in app/Module/StatisticsChartModule.php - About 1 hr to fix

          Function myPlot has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              private function myPlot(
                  string $chart_title,
                  array $x_axis,
                  string $x_axis_title,
                  array $ydata,
          Severity: Minor
          Found in app/Module/StatisticsChartModule.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method myPlot has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  string $chart_title,
                  array $x_axis,
                  string $x_axis_title,
                  array $ydata,
                  string $y_axis_title,
          Severity: Major
          Found in app/Module/StatisticsChartModule.php - About 50 mins to fix

            Method fillYData has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private function fillYData($x, $z, $value, array $x_axis, array $z_axis, array &$ydata): void
            Severity: Minor
            Found in app/Module/StatisticsChartModule.php - About 45 mins to fix

              Function fillYData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function fillYData($x, $z, $value, array $x_axis, array $z_axis, array &$ydata): void
                  {
                      $x = $this->findAxisEntry($x, $x_axis);
                      $z = $this->findAxisEntry($z, $z_axis);
              
              
              Severity: Minor
              Found in app/Module/StatisticsChartModule.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function axisNumbers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function axisNumbers(string $boundaries_csv): array
                  {
                      $boundaries = explode(',', $boundaries_csv);
              
                      $boundaries = array_map(static function (string $x): int {
              Severity: Minor
              Found in app/Module/StatisticsChartModule.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                              return response($this->myPlot($chart_title, $x_axis, $x_axis_title, $ydata, $y_axis_title, $z_axis, $y_axis_type));
              Severity: Major
              Found in app/Module/StatisticsChartModule.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return response($this->myPlot($chart_title, $x_axis, $x_axis_title, $ydata, $y_axis_title, $z_axis, $y_axis_type));
                Severity: Major
                Found in app/Module/StatisticsChartModule.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return response($this->myPlot($chart_title, $x_axis, $x_axis_title, $ydata, $y_axis_title, $z_axis, $y_axis_type));
                  Severity: Major
                  Found in app/Module/StatisticsChartModule.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return response($this->myPlot($chart_title, $x_axis, $x_axis_title, $ydata, $y_axis_title, $z_axis, $y_axis_type));
                    Severity: Major
                    Found in app/Module/StatisticsChartModule.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return response($this->myPlot($chart_title, $x_axis, $x_axis_title, $ydata, $y_axis_title, $z_axis, $y_axis_type));
                      Severity: Major
                      Found in app/Module/StatisticsChartModule.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return response($this->myPlot($chart_title, $x_axis, $x_axis_title, $ydata, $y_axis_title, $z_axis, $y_axis_type));
                        Severity: Major
                        Found in app/Module/StatisticsChartModule.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return response($this->myPlot($chart_title, $x_axis, $x_axis_title, $ydata, $y_axis_title, $z_axis, $y_axis_type));
                          Severity: Major
                          Found in app/Module/StatisticsChartModule.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return response($this->myPlot($chart_title, $x_axis, $x_axis_title, $ydata, $y_axis_title, $z_axis, $y_axis_type));
                            Severity: Major
                            Found in app/Module/StatisticsChartModule.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                              return response($this->myPlot($chart_title, $x_axis, $x_axis_title, $ydata, $y_axis_title, $z_axis, $y_axis_type));
                              Severity: Major
                              Found in app/Module/StatisticsChartModule.php - About 30 mins to fix

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                            case self::X_AXIS_BIRTH_MONTH:
                                                $chart_title  = I18N::translate('Month of birth');
                                                $x_axis_title = I18N::translate('Month');
                                                $x_axis       = $this->axisMonths();
                                
                                
                                Severity: Major
                                Found in app/Module/StatisticsChartModule.php and 2 other locations - About 1 day to fix
                                app/Module/StatisticsChartModule.php on lines 325..372
                                app/Module/StatisticsChartModule.php on lines 416..463

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 390.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                            case self::X_AXIS_DEATH_MONTH:
                                                $chart_title  = I18N::translate('Month of death');
                                                $x_axis_title = I18N::translate('Month');
                                                $x_axis       = $this->axisMonths();
                                
                                
                                Severity: Major
                                Found in app/Module/StatisticsChartModule.php and 2 other locations - About 1 day to fix
                                app/Module/StatisticsChartModule.php on lines 276..323
                                app/Module/StatisticsChartModule.php on lines 416..463

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 390.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                            case self::X_AXIS_FIRST_CHILD_MONTH:
                                                $chart_title  = I18N::translate('Month of birth of first child in a relation');
                                                $x_axis_title = I18N::translate('Month');
                                                $x_axis       = $this->axisMonths();
                                
                                
                                Severity: Major
                                Found in app/Module/StatisticsChartModule.php and 2 other locations - About 1 day to fix
                                app/Module/StatisticsChartModule.php on lines 276..323
                                app/Module/StatisticsChartModule.php on lines 325..372

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 390.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                There are no issues that match your filters.

                                Category
                                Status