Sign upLogin

fission-suite/webnative

View on GitHub
Star

Showing 283 of 283 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const a: Path.File<Path.PartitionedNonEmpty<Path.Private>> = Path.file("private", "a")
Severity: Minor
Found in src/path/index.node.test.ts and 1 other location - About 30 mins to fix
src/path/index.node.test.ts on lines 29..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

      return { ok: false, error: new LinkingError("Consumer received a closed UCAN session key does not match the session key") }
Severity: Major
Found in src/linking/consumer.ts - About 30 mins to fix

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

      async put(): Promise<CID> {
    const { cid } = await this.putDetailed()
    return cid
  }
    Severity: Major
    Found in src/fs/bare/file.ts and 3 other locations - About 30 mins to fix
    src/fs/base/file.ts on lines 17..20
    src/fs/base/tree.ts on lines 20..23
    src/fs/protocol/private/mmpt.ts on lines 53..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

        return CID.parse(val[ "/" ])
    Severity: Major
    Found in src/common/cid.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return reloadedNext === undefined ? null : this.getRecurse(reloadedNext, rest)
      Severity: Major
      Found in src/fs/v1/PrivateTree.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return parseResult
        Severity: Major
        Found in src/linking/consumer.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return child
          Severity: Major
          Found in src/fs/v1/PublicTree.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return this.getRecurse(child.subSkeleton, nextPath)
            Severity: Major
            Found in src/fs/v1/PublicTree.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return { ok: false, error: new LinkingError("Consumer received a closed UCAN that was missing a session key in facts.") }
              Severity: Major
              Found in src/linking/consumer.ts - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      const key = await this.crypto.aes.genKey(DEFAULT_AES_ALG).then(this.crypto.aes.exportKey)
                Severity: Minor
                Found in src/fs/v1/PrivateTree.ts and 1 other location - About 30 mins to fix
                src/fs/v1/PrivateTree.ts on lines 189..189

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                  return ucan || null
                Severity: Major
                Found in src/capabilities.ts - About 30 mins to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                  export function combine(a: DirectoryPath<Segments>, b: DirectoryPath<Segments>): DirectoryPath<Segments>
                  Severity: Minor
                  Found in src/path/index.ts and 2 other locations - About 30 mins to fix
                  src/path/index.ts on lines 169..169
                  src/path/index.ts on lines 177..177

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Avoid too many return statements within this function.
                  Open

                      return { ok: true, value: sessionKey }
                  Severity: Major
                  Found in src/linking/consumer.ts - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        const b: Path.Directory<Path.PartitionedNonEmpty<Path.Public>> = Path.directory("public", "a")
                    Severity: Minor
                    Found in src/path/index.node.test.ts and 1 other location - About 30 mins to fix
                    src/path/index.node.test.ts on lines 47..47

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this function.
                    Open

                        if (!hasRaw) return null
                    Severity: Major
                    Found in src/capabilities.ts - About 30 mins to fix

                      Identical blocks of code found in 4 locations. Consider refactoring.
                      Open

                        async put(): Promise<CID> {
    const { cid } = await this.putDetailed()
    return cid
  }
                      Severity: Major
                      Found in src/fs/base/tree.ts and 3 other locations - About 30 mins to fix
                      src/fs/bare/file.ts on lines 33..36
                      src/fs/base/file.ts on lines 17..20
                      src/fs/protocol/private/mmpt.ts on lines 53..56

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 45.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                      export function combine(a: DirectoryPath<Segments>, b: FilePath<Segments>): FilePath<Segments>
                      Severity: Minor
                      Found in src/path/index.ts and 2 other locations - About 30 mins to fix
                      src/path/index.ts on lines 173..173
                      src/path/index.ts on lines 177..177

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 45.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function runOnChildTree has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        async runOnChildTree(node: Tree, relPath: Path.Segments, fn: (tree: Tree) => Promise<Tree>): Promise<Tree> {
    let tree = node

    if (relPath.length) {
      if (!await tree.exists(relPath)) await tree.mkdir(relPath)
                      Severity: Minor
                      Found in src/fs/filesystem.ts - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function resolveSoftLink has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        static async resolveSoftLink(
    crypto: Crypto.Implementation,
    depot: Depot.Implementation,
    manners: Manners.Implementation,
    reference: Reference.Implementation,
                      Severity: Minor
                      Found in src/fs/v1/PrivateTree.ts - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      export const getPath = (skeleton: Skeleton, path: NonEmptyPath): SkeletonInfo | SoftLink | null => {
  const head = path[0]
  const child = skeleton[head] || null
  const nextPath = nextNonEmpty(path)
  if (child === null || nextPath === null || isSoftLink(child)) {
                      Severity: Minor
                      Found in src/fs/protocol/public/skeleton.ts - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language