Sign upLogin

fission-suite/webnative

View on GitHub
Star
src/fs/v1/PublicTree.ts

Summary

Maintainability
D
1 day
Test Coverage

File PublicTree.ts has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { CID } from "multiformats/cid"

import * as Common from "../../common/index.js"
import * as Check from "../types/check.js"
import * as Depot from "../../components/depot/implementation.js"
Severity: Minor
Found in src/fs/v1/PublicTree.ts - About 2 hrs to fix

    Function getRecurse has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      async getRecurse(skel: Skeleton, path: NonEmptyPath): Promise<SkeletonInfo | Child | null> {
    const head = path[ 0 ]
    const child = skel[ head ] || null
    const nextPath = nextNonEmpty(path)
    Severity: Minor
    Found in src/fs/v1/PublicTree.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getDirectChild has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      async getDirectChild(name: string): Promise<Child | null> {
    let child = null

    if (this.children[ name ]) {
      return this.children[ name ]
    Severity: Minor
    Found in src/fs/v1/PublicTree.ts - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return null
    Severity: Major
    Found in src/fs/v1/PublicTree.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return child
      Severity: Major
      Found in src/fs/v1/PublicTree.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return this.getRecurse(child.subSkeleton, nextPath)
        Severity: Major
        Found in src/fs/v1/PublicTree.ts - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            async createOrUpdateChildFile(content: Uint8Array, name: string, onUpdate: Maybe<UpdateCallback>): Promise<PublicFile> {
    const existing = await this.getDirectChild(name)
    let file: PublicFile
    if (existing === null) {
      file = await PublicFile.create(this.depot, content)
          Severity: Major
          Found in src/fs/v1/PublicTree.ts and 1 other location - About 7 hrs to fix
          src/fs/bare/tree.ts on lines 71..83

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 177.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status