Sign upLogin

fission-suite/webnative

View on GitHub
Star
src/linking/consumer.ts

Summary

Maintainability
F
3 days
Test Coverage

Function createConsumer has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

export const createConsumer = async (
  dependencies: Dependencies,
  options: { username: string }
): Promise<AccountLinkingConsumer> => {
  const { username } = options
Severity: Minor
Found in src/linking/consumer.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createConsumer has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const createConsumer = async (
  dependencies: Dependencies,
  options: { username: string }
): Promise<AccountLinkingConsumer> => {
  const { username } = options
Severity: Major
Found in src/linking/consumer.ts - About 3 hrs to fix

    Function handleMessage has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const handleMessage = async (event: MessageEvent): Promise<void> => {
    const { data } = event
    const message = data.arrayBuffer ? new TextDecoder().decode(await data.arrayBuffer()) : data

    switch (ls.step) {
    Severity: Minor
    Found in src/linking/consumer.ts - About 2 hrs to fix

      Function handleSessionKey has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const handleSessionKey = async (
  crypto: Crypto.Implementation,
  temporaryRsaPrivateKey: CryptoKey,
  data: string
): Promise<Result<Uint8Array, Error>> => {
      Severity: Minor
      Found in src/linking/consumer.ts - About 1 hr to fix

        Function handleSessionKey has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        export const handleSessionKey = async (
  crypto: Crypto.Implementation,
  temporaryRsaPrivateKey: CryptoKey,
  data: string
): Promise<Result<Uint8Array, Error>> => {
        Severity: Minor
        Found in src/linking/consumer.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function linkDevice has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const linkDevice = async (
  auth: Auth.Implementation<Components>,
  crypto: Crypto.Implementation,
  sessionKey: Uint8Array,
  username: string,
        Severity: Minor
        Found in src/linking/consumer.ts - About 1 hr to fix

          Function linkDevice has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          export const linkDevice = async (
  auth: Auth.Implementation<Components>,
  crypto: Crypto.Implementation,
  sessionKey: Uint8Array,
  username: string,
          Severity: Minor
          Found in src/linking/consumer.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return parseResult
          Severity: Major
          Found in src/linking/consumer.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return { ok: false, error: new LinkingError("Consumer received a closed UCAN session key does not match the session key") }
            Severity: Major
            Found in src/linking/consumer.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return parseResult
              Severity: Major
              Found in src/linking/consumer.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return { ok: false, error: new LinkingError("Consumer received a closed UCAN that was missing a session key in facts.") }
                Severity: Major
                Found in src/linking/consumer.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return { ok: true, value: sessionKey }
                  Severity: Major
                  Found in src/linking/consumer.ts - About 30 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                      const typeGuard = (message: unknown): message is { iv: string; msg: string } => {
    return Check.isObject(message)
      && "iv" in message && typeof message.iv === "string"
      && "msg" in message && typeof message.msg === "string"
  }
                    Severity: Major
                    Found in src/linking/consumer.ts and 1 other location - About 3 hrs to fix
                    src/linking/producer.ts on lines 245..249

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 97.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        try {
      message = await crypto.aes.decrypt(
        Uint8arrays.fromString(msg, "base64pad"),
        sessionKey,
        Crypto.SymmAlg.AES_GCM,
                    Severity: Major
                    Found in src/linking/consumer.ts and 2 other locations - About 1 hr to fix
                    src/linking/consumer.ts on lines 221..230
                    src/linking/producer.ts on lines 258..267

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 70.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        try {
      encodedUcan = await crypto.aes.decrypt(
        Uint8arrays.fromString(msg, "base64pad"),
        sessionKey,
        Crypto.SymmAlg.AES_GCM,
                    Severity: Major
                    Found in src/linking/consumer.ts and 2 other locations - About 1 hr to fix
                    src/linking/consumer.ts on lines 328..337
                    src/linking/producer.ts on lines 258..267

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 70.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export type AccountLinkingConsumer = {
  on: <K extends keyof ConsumerEventMap>(eventName: K, listener: EventListener<ConsumerEventMap[ K ]>) => void
  cancel: () => void
}
                    Severity: Major
                    Found in src/linking/consumer.ts and 1 other location - About 1 hr to fix
                    src/linking/producer.ts on lines 19..22

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 69.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export type Dependencies = {
  auth: Auth.Implementation<Components>
  crypto: Crypto.Implementation
  manners: Manners.Implementation
}
                    Severity: Minor
                    Found in src/linking/consumer.ts and 1 other location - About 55 mins to fix
                    src/linking/producer.ts on lines 34..38

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 54.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status