Sign upLogin

flexirest/flexirest

View on GitHub
Star
lib/flexirest/json_api_proxy.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method pluck_attributes_and_relationships has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

      def pluck_attributes_and_relationships(record, rels)
        cleaned = { id: record['id'] }
        relationships = Hash[rels.map { |rel| [rel, singular?(rel)] }]

        relationships.each do |rel_name, is_singular|
Severity: Minor
Found in lib/flexirest/json_api_proxy.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fetch_attributes_and_relationships has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def fetch_attributes_and_relationships(record, included, rels, base: nil)
        base = Array(base) unless base.is_a?(Array)
        rels = rels - [base.last]
        rels_object = record['relationships']
Severity: Minor
Found in lib/flexirest/json_api_proxy.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pluck_attributes_and_relationships has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def pluck_attributes_and_relationships(record, rels)
        cleaned = { id: record['id'] }
        relationships = Hash[rels.map { |rel| [rel, singular?(rel)] }]

        relationships.each do |rel_name, is_singular|
Severity: Minor
Found in lib/flexirest/json_api_proxy.rb - About 1 hr to fix

    Method fetch_attributes_and_relationships has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def fetch_attributes_and_relationships(record, included, rels, base: nil)
        base = Array(base) unless base.is_a?(Array)
        rels = rels - [base.last]
        rels_object = record['relationships']
    Severity: Minor
    Found in lib/flexirest/json_api_proxy.rb - About 1 hr to fix

      Method parse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def parse(body, object)
        # Save resource class for building lazy association loaders
        save_resource_class(object)

        # According to the spec:
      Severity: Minor
      Found in lib/flexirest/json_api_proxy.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status