Sign upLogin

floere/phony

View on GitHub
Star
lib/phony/country.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method format_cc_ndc has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def format_cc_ndc trunk, ndc, local, type, space, parentheses, use_trunk
      # Note: We mark NDCs that are of type "none" with false (nil trips plausible?). This would result in false being printed.
      #       Therefore we set NDC to nil when formatting.
      ndc = nil if ndc == false
      case type
Severity: Minor
Found in lib/phony/country.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method format_cc_ndc has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def format_cc_ndc trunk, ndc, local, type, space, parentheses, use_trunk
      # Note: We mark NDCs that are of type "none" with false (nil trips plausible?). This would result in false being printed.
      #       Therefore we set NDC to nil when formatting.
      ndc = nil if ndc == false
      case type
Severity: Minor
Found in lib/phony/country.rb - About 1 hr to fix

    Method format_cc_ndc has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def format_cc_ndc trunk, ndc, local, type, space, parentheses, use_trunk
    Severity: Major
    Found in lib/phony/country.rb - About 50 mins to fix

      Method format_with_ndc has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def format_with_ndc format, cc, ndc, local, space
      Severity: Minor
      Found in lib/phony/country.rb - About 35 mins to fix

        Method plausible? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def plausible? rest, hints = {}
      local, _, ndc, *rest = internal_split rest
      
      # Element based checking.
      #
        Severity: Minor
        Found in lib/phony/country.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return false unless local
        Severity: Major
        Found in lib/phony/country.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return local.plausible? rest, hints
          Severity: Major
          Found in lib/phony/country.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status