Sign upLogin

florianschmitt/connection-backend

View on GitHub
Star
src/main/kotlin/de/florianschmitt/service/MailService.kt

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    fun requestAcceptedConfirmationForVolunteer(request: ERequest) {
        request.acceptedByVolunteer ?: throw NullPointerException("request.acceptedByVolunteer cannot be null")

        val subjectTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_ACCEPTED_VOLUNTEER_SUBJECT)
        val contentTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_ACCEPTED_VOLUNTEER_CONTENT)
Severity: Major
Found in src/main/kotlin/de/florianschmitt/service/MailService.kt and 2 other locations - About 3 hrs to fix
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 74..84
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 86..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 239.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    fun requestFinishedInformVolunteer(request: ERequest) {
        request.acceptedByVolunteer ?: throw NullPointerException("request.acceptedByVolunteer cannot be null")

        val subjectTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_FINISHED_ASK_FEEDBACK_VOLUNTEER_SUBJECT)
        val contentTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_FINISHED_ASK_FEEDBACK_VOLUNTEER_CONTENT)
Severity: Major
Found in src/main/kotlin/de/florianschmitt/service/MailService.kt and 2 other locations - About 3 hrs to fix
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 50..60
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 74..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 239.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    fun requestCanceledInformVolunteer(request: ERequest) {
        request.acceptedByVolunteer ?: throw NullPointerException("request.acceptedByVolunteer cannot be null")

        val subjectTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_CANCELED_INFORM_VOLUNTEER_SUBJECT)
        val contentTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_CANCELED_INFORM_VOLUNTEER_CONTENT)
Severity: Major
Found in src/main/kotlin/de/florianschmitt/service/MailService.kt and 2 other locations - About 3 hrs to fix
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 50..60
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 86..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 239.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    fun requestFinishedInformRequester(request: ERequest) {
        val subjectTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_FINISHED_ASK_FEEDBACK_REQUESTER_SUBJECT)
        val contentTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_FINISHED_ASK_FEEDBACK_REQUESTER_CONTENT)

        val subject = stringTemplateService.replace(subjectTemplate, request.requesterName!!, request)
Severity: Major
Found in src/main/kotlin/de/florianschmitt/service/MailService.kt and 2 other locations - About 2 hrs to fix
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 20..28
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 30..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    fun requestExpired(request: ERequest) {
        val subjectTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_EXPIRED_REQUESTER_SUBJECT)
        val contentTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_EXPIRED_REQUESTER_CONTENT)

        val subject = stringTemplateService.replace(subjectTemplate, request.requesterName!!, request)
Severity: Major
Found in src/main/kotlin/de/florianschmitt/service/MailService.kt and 2 other locations - About 2 hrs to fix
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 20..28
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 98..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    fun requestConfirmation(request: ERequest) {
        val subjectTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_CONFIRMATION_SUBJECT)
        val contentTemplate = templateService.getTemplate(TemplateFixtures.REQUEST_CONFIRMATION_CONTENT)

        val subject = stringTemplateService.replace(subjectTemplate, request.requesterName!!, request)
Severity: Major
Found in src/main/kotlin/de/florianschmitt/service/MailService.kt and 2 other locations - About 2 hrs to fix
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 30..38
src/main/kotlin/de/florianschmitt/service/MailService.kt on lines 98..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status