Sign upLogin

fluent/fluentd-ui

View on GitHub
Star
app/models/concerns/fluentd/setting/plugin.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method register_plugin has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def register_plugin(type, name)
          self.plugin_type = type
          self.plugin_name = name

          if ["filter", "output"].include?(type)
Severity: Minor
Found in app/models/concerns/fluentd/setting/plugin.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method register_plugin has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def register_plugin(type, name)
          self.plugin_type = type
          self.plugin_name = name

          if ["filter", "output"].include?(type)
Severity: Minor
Found in app/models/concerns/fluentd/setting/plugin.rb - About 1 hr to fix

    Method load_plugin_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def load_plugin_config
          dumped_config = {}
          plugin_class.ancestors.reverse_each do |klass|
            next unless klass.respond_to?(:dump_config_definition)
            dumped_config_definition = klass.dump_config_definition
    Severity: Minor
    Found in app/models/concerns/fluentd/setting/plugin.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status