Sign upLogin

fluent/fluentd-ui

View on GitHub
Star
app/models/fluentd/agent/common.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Agent has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Agent
    module Common
      attr_reader :extra_options

      def self.included(base)
Severity: Minor
Found in app/models/fluentd/agent/common.rb - About 2 hrs to fix

    Method dump_parsed_config has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def dump_parsed_config(parsed_config)
        content = "".dup
        sources = parsed_config["source"] || []
        filters = parsed_config["filter"] || []
        matches = parsed_config["match"] || []
    Severity: Minor
    Found in app/models/fluentd/agent/common.rb - About 1 hr to fix

      Method parse_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def parse_config(content)
        scanner = StringScanner.new(content)
        contents = Hash.new {|h, k| h[k] = [] }
        until scanner.eos? do
          started = scanner.pos
      Severity: Minor
      Found in app/models/fluentd/agent/common.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status