Sign upLogin

fluent/fluentd-ui

View on GitHub
Star
app/models/fluentd/setting/config.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method delete_element has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def delete_element(name, arg, element)
        if name == "label"
          label_section = fl_config.elements(name: name, arg: arg).first
          original_size = label_section.elements.size
          remaining_elements = label_section.elements.reject do |e|
Severity: Minor
Found in app/models/fluentd/setting/config.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method delete_element has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def delete_element(name, arg, element)
        if name == "label"
          label_section = fl_config.elements(name: name, arg: arg).first
          original_size = label_section.elements.size
          remaining_elements = label_section.elements.reject do |e|
Severity: Minor
Found in app/models/fluentd/setting/config.rb - About 1 hr to fix

    Method group_by_label has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def group_by_label
        hash = Hash.new{|h, k| h[k] = {} }
        sources.each do |source|
          label = source["@label"] || source["label"]
          if label
    Severity: Minor
    Found in app/models/fluentd/setting/config.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return element
    Severity: Major
    Found in app/models/fluentd/setting/config.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status