Sign upLogin

fluent/fluentd

View on GitHub
Star
lib/fluent/command/cat.rb

Summary

Maintainability
B
6 hrs
Test Coverage

File cat.rb has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'optparse'
require 'fluent/env'
require 'fluent/time'
require 'fluent/msgpack_factory'
require 'fluent/version'
Severity: Minor
Found in lib/fluent/command/cat.rb - About 2 hrs to fix

    Method write has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def write(record)
    unless secondary_record?(record)
      if record.class != Hash
        raise ArgumentError, "Input must be a map (got #{record.class})"
      end
    Severity: Minor
    Found in lib/fluent/command/cat.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method try_connect has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def try_connect
    begin
      now = Time.now.to_i

      unless @error_history.empty?
    Severity: Minor
    Found in lib/fluent/command/cat.rb - About 1 hr to fix

      Method try_connect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def try_connect
    begin
      now = Time.now.to_i

      unless @error_history.empty?
      Severity: Minor
      Found in lib/fluent/command/cat.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method on_timer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def on_timer
    now = Time.now.to_i

    synchronize {
      unless @pending.empty?
      Severity: Minor
      Found in lib/fluent/command/cat.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status