Method start has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring. Open
def start
super
@children_mutex = Mutex.new
@children = []- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method configure has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
def configure(conf)
exec_filter_compat_parameters_convert!(conf)
compat_parameters_convert(conf, :buffer)
if inject_section = conf.elements('inject').first- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method start has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
def start
super
@children_mutex = Mutex.new
@children = []File out_exec_filter.rb has 259 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'fluent/plugin/output'
require 'fluent/env'
require 'fluent/config/error'
require 'yajl'Method configure has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def configure(conf)
exec_filter_compat_parameters_convert!(conf)
compat_parameters_convert(conf, :buffer)
if inject_section = conf.elements('inject').firstMethod on_record has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def on_record(time, record)
tag = extract_tag_from_record(record)
tag = @added_prefix_string + tag if tag && @add_prefix
tag ||= @tag
time ||= extract_time_from_record(record) || Fluent::EventTime.now- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method write has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def write(chunk)
try_times = 0
while true
r = @rr = (@rr + 1) % @children.length
if @children[r].pid && writeio = @children[r].writeio- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method exec_filter_compat_parameters_copy_to_subsection! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def exec_filter_compat_parameters_copy_to_subsection!(conf, subsection_name, params)
return unless conf.elements(subsection_name).empty?
return unless params.keys.any?{|k| conf.has_key?(k) }
hash = {}
params.each_pair do |compat, current|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
case
when @parser.implement?(:parse_io)
@parser.parse_io(io, &method(:on_record))
when @parser.implement?(:parse_partial_data)
until io.eof?- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 52.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76