Sign upLogin

fluent/fluentd

View on GitHub
Star
lib/fluent/plugin/out_forward/load_balancer.rb

Summary

Maintainability
A
4 hrs
Test Coverage

Method rebuild_weight_array has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def rebuild_weight_array(nodes)
        standby_nodes, regular_nodes = nodes.select { |e| e.weight > 0 }.partition {|n|
          n.standby?
        }
Severity: Minor
Found in lib/fluent/plugin/out_forward/load_balancer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method rebuild_weight_array has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def rebuild_weight_array(nodes)
        standby_nodes, regular_nodes = nodes.select { |e| e.weight > 0 }.partition {|n|
          n.standby?
        }
Severity: Minor
Found in lib/fluent/plugin/out_forward/load_balancer.rb - About 1 hr to fix

    Method select_healthy_node has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def select_healthy_node
        error = nil

        # Don't care about the change of @weight_array's size while looping since
        # it's only used for determining the number of loops and it is not so important.
    Severity: Minor
    Found in lib/fluent/plugin/out_forward/load_balancer.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status