Sign upLogin

fluent/fluentd

View on GitHub
Star
lib/fluent/timezone.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method formatter has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.formatter(timezone = nil, format = nil)
      if timezone.nil?
        return nil
      end
Severity: Minor
Found in lib/fluent/timezone.rb - About 1 hr to fix

    Method formatter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.formatter(timezone = nil, format = nil)
      if timezone.nil?
        return nil
      end
    Severity: Minor
    Found in lib/fluent/timezone.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.validate(timezone)
      # If the specified timezone is nil.
      if timezone.nil?
        # Invalid.
        return false
    Severity: Minor
    Found in lib/fluent/timezone.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

              return nil
    Severity: Major
    Found in lib/fluent/timezone.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return Proc.new {|time|
            time = time.to_time
            format.exec(time.localtime(tz.period_for_utc(time).utc_total_offset))
          }
      Severity: Major
      Found in lib/fluent/timezone.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return nil
        Severity: Major
        Found in lib/fluent/timezone.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return Proc.new {|time|
            time = time.to_time
            time.localtime(tz.period_for_utc(time).utc_total_offset).strftime(format)
          }
          Severity: Major
          Found in lib/fluent/timezone.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return false
            Severity: Major
            Found in lib/fluent/timezone.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                        return Proc.new {|time|
            time = time.to_time
            time.localtime(tz.period_for_utc(time).utc_total_offset).iso8601
          }
              Severity: Major
              Found in lib/fluent/timezone.rb - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status