Sign upLogin

fnando/browser

View on GitHub
Star

Showing 5 of 10 total issues

Class Base has 43 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Base
    include DetectVersion

    attr_reader :ua
Severity: Minor
Found in lib/browser/base.rb - About 5 hrs to fix

    Class Platform has 34 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class Platform
    include DetectVersion

    attr_reader :ua
    Severity: Minor
    Found in lib/browser/platform.rb - About 4 hrs to fix

      Class Device has 32 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Device
    attr_reader :ua

    # Hold the list of device matchers.
    # Order is important.
      Severity: Minor
      Found in lib/browser/device.rb - About 4 hrs to fix

        Method matchers has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.matchers
    @matchers ||= [
      Nokia,
      UCBrowser,
      PhantomJS,
        Severity: Minor
        Found in lib/browser/browser.rb - About 1 hr to fix

          Method detect_version? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private def detect_version?(actual_version, expected_version)
      return true unless expected_version
      return false if expected_version && !actual_version

      expected_version = parse_version(expected_version)
          Severity: Minor
          Found in lib/browser/detect_version.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language