Sign upLogin

fnando/test_squad

View on GitHub
Star

Showing 6 of 6 total issues

Function PhantomJS has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Mocha.reporters.PhantomJS = function(runner) {
  if (!navigator.userAgent.match(/phantomjs/i)) {
    return;
  }
Severity: Major
Found in app/assets/javascripts/test_squad/mocha-reporter.js - About 3 hrs to fix

    Function onCallback has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      page.onCallback = function(message){
    if (message.name === 'suite start') {
      suite = {tests: []};
      suite.title = message.title;
    Severity: Major
    Found in phantomjs/runner.js - About 2 hrs to fix

      Function PhantomReporter has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        jasmineRequire.PhantomReporter = function() {
    function PhantomReporter(options) {
      var stats = {
        passes: 0,
        fails: 0,
      Severity: Major
      Found in app/assets/javascripts/test_squad/jasmine-phantom.js - About 2 hrs to fix

        Function PhantomReporter has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function PhantomReporter(options) {
      var stats = {
        passes: 0,
        fails: 0,
        pending: 0,
        Severity: Major
        Found in app/assets/javascripts/test_squad/jasmine-phantom.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            runner.on("end", function(){
    stats.elapsed = new Date().getTime() - start;
    callPhantom({
      name: "end",
      stats: stats
          Severity: Minor
          Found in app/assets/javascripts/test_squad/mocha-reporter.js and 1 other location - About 40 mins to fix
          app/assets/javascripts/test_squad/jasmine-phantom.js on lines 27..34

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                this.jasmineDone = function() {
        stats.elapsed = new Date().getTime() - start;

        callPhantom({
          name: "end",
          Severity: Minor
          Found in app/assets/javascripts/test_squad/jasmine-phantom.js and 1 other location - About 40 mins to fix
          app/assets/javascripts/test_squad/mocha-reporter.js on lines 33..39

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language