Sign upLogin

fog/fog-aws

View on GitHub
Star

Showing 1,218 of 1,218 total issues

Method describe_security_groups has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def describe_security_groups(filters = {})
          unless filters.is_a?(Hash)
            Fog::Logger.deprecation("describe_security_groups with #{filters.class} param is deprecated, use describe_security_groups('group-name' => []) instead [light_black](#{caller.first})[/]")
            filters = {'group-name' => [*filters]}
          end
Severity: Major
Found in lib/fog/aws/requests/compute/describe_security_groups.rb - About 2 hrs to fix

    Class Group has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

          class Group < Fog::Model
        identity  :id,                        :aliases => 'AutoScalingGroupName'
        attribute :arn,                       :aliases => 'AutoScalingGroupARN'
        attribute :availability_zones,        :aliases => 'AvailabilityZones'
        attribute :created_at,                :aliases => 'CreatedTime'
    Severity: Minor
    Found in lib/fog/aws/models/auto_scaling/group.rb - About 2 hrs to fix

      Method end_element has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                def end_element(name)
            case name
            when 'amiLaunchIndex'
              @instance[name] = value.to_i
            when 'architecture', 'clientToken', 'dnsName', 'hypervisor', 'imageId',
      Severity: Major
      Found in lib/fog/aws/parsers/compute/run_instances.rb - About 2 hrs to fix

        Method create_vpc has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def create_vpc(cidrBlock, options = {})
          Excon::Response.new.tap do |response|
            if cidrBlock
              response.status = 200
              vpc_id = Fog::AWS::Mock.vpc_id
        Severity: Major
        Found in lib/fog/aws/requests/compute/create_vpc.rb - About 2 hrs to fix

          Method create_function has 62 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def create_function(params={})
          response = Excon::Response.new

          runtime = params.delete('Runtime') || 'nodejs'
          if !%w(nodejs java8).include?(runtime)
          Severity: Major
          Found in lib/fog/aws/requests/lambda/create_function.rb - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              module AWS
    class Compute
      class Real
        require 'fog/aws/parsers/compute/monitor_unmonitor_instances'
            Severity: Major
            Found in lib/fog/aws/requests/compute/unmonitor_instances.rb and 1 other location - About 2 hrs to fix
            lib/fog/aws/requests/compute/monitor_instances.rb on lines 2..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              module AWS
    class Compute
      class Real
        require 'fog/aws/parsers/compute/monitor_unmonitor_instances'
            Severity: Major
            Found in lib/fog/aws/requests/compute/monitor_instances.rb and 1 other location - About 2 hrs to fix
            lib/fog/aws/requests/compute/unmonitor_instances.rb on lines 2..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method end_element has 61 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                      def end_element(name)
            if @in_tag_set
              case name
              when 'item'
                @nic['tagSet'][@tag['key']] = @tag['value']
            Severity: Major
            Found in lib/fog/aws/parsers/compute/network_interface_parser.rb - About 2 hrs to fix

              Method end_element has 61 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                        def end_element(name)
            super
            case name
            when *@contexts
              @context.pop
              Severity: Major
              Found in lib/fog/aws/parsers/ecs/service.rb - About 2 hrs to fix

                Method create_network_interface has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        def create_network_interface(subnetId, options = {})
          response = Excon::Response.new
          if subnetId
            subnet = self.data[:subnets].find{ |s| s['subnetId'] == subnetId }
            if subnet.nil?
                Severity: Major
                Found in lib/fog/aws/requests/compute/create_network_interface.rb - About 2 hrs to fix

                  Method run_task has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          def run_task(params={})
          response = Excon::Response.new
          response.status = 200

          unless task_def_id = params.delete('taskDefinition')
                  Severity: Major
                  Found in lib/fog/aws/requests/ecs/run_task.rb - About 2 hrs to fix

                    Method save has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def save(options = {})
          requires :body, :directory, :key
          if options != {}
            Fog::Logger.deprecation("options param is deprecated, use acl= instead [light_black](#{caller.first})[/]")
          end
                    Severity: Minor
                    Found in lib/fog/aws/models/storage/file.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method end_element has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                              def end_element(name)
            if @in_outputs
              case name
              when 'OutputKey', 'OutputValue', 'Description'
                @output[name] = value
                    Severity: Minor
                    Found in lib/fog/aws/parsers/cloud_formation/describe_stacks.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method modify_db_instance has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def modify_db_instance(db_name, apply_immediately, _options={})
          options = _options.dup
          response = Excon::Response.new
          if server = self.data[:servers][db_name]
            if server["DBInstanceStatus"] != "available"
                    Severity: Minor
                    Found in lib/fog/aws/requests/rds/modify_db_instance.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method replace_route has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def replace_route(route_table_id, destination_cidr_block, options = {})
          options['instanceOwnerId'] ||= nil
          options['DestinationCidrBlock'] ||= destination_cidr_block

          route_table = self.data[:route_tables].find { |routetable| routetable["routeTableId"].eql? route_table_id }
                    Severity: Minor
                    Found in lib/fog/aws/requests/compute/replace_route.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method put_attributes has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def put_attributes(domain_name, item_name, attributes, options = {})
          options[:expect] = {} unless options[:expect]
          options[:replace] = [] unless options[:replace]
          response = Excon::Response.new
          if self.data[:domains][domain_name]
                    Severity: Minor
                    Found in lib/fog/aws/requests/simpledb/put_attributes.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method create_service has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def create_service(params={})
          response = Excon::Response.new
          response.status = 200

          e = Fog::AWS::ECS::Error
                    Severity: Minor
                    Found in lib/fog/aws/requests/ecs/create_service.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method get_attributes has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                            def get_attributes(domain_name, item_name, options = {})
          if options.is_a?(Array)
            Fog::Logger.deprecation("get_attributes with array attributes param is deprecated, use 'AttributeName' => attributes) instead [light_black](#{caller.first})[/]")
            options['AttributeName'] ||= options if options.is_a?(Array)
          end
                    Severity: Minor
                    Found in lib/fog/aws/requests/simpledb/get_attributes.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method end_element has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                              def end_element(name)
            case name
            when 'AvailabilityZone', 'ClusterIdentifier', 'ClusterStatus', 'ClusterSubnetGroupName', 'DBName',
              'MasterUsername', 'ModifyStatus', 'PreferredMaintenanceWindow', 'VpcId'
              @cluster[name] = value
                    Severity: Major
                    Found in lib/fog/aws/parsers/redshift/cluster_parser.rb - About 2 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              def initialize(options={})
          @use_iam_profile = options[:use_iam_profile]
          @instrumentor       = options[:instrumentor]
          @instrumentor_name  = options[:instrumentor_name] || 'fog.aws.rds'
          @connection_options     = options[:connection_options] || {}
                      Severity: Major
                      Found in lib/fog/aws/rds.rb and 1 other location - About 2 hrs to fix
                      lib/fog/aws/ecs.rb on lines 58..73

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 89.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language