Sign upLogin

fog/fog-aws

View on GitHub
Star
lib/fog/aws/compute.rb

Summary

Maintainability
F
3 days
Test Coverage
B
84%

File compute.rb has 587 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Fog
  module AWS
    class Compute < Fog::Service
      extend Fog::AWS::CredentialFetcher::ServiceMethods
Severity: Major
Found in lib/fog/aws/compute.rb - About 1 day to fix

    Method data has 105 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def self.data
          @data ||= Hash.new do |hash, region|
            hash[region] = Hash.new do |region_hash, key|
              owner_id = Fog::AWS::Mock.owner_id
              security_group_id = Fog::AWS::Mock.security_group_id
    Severity: Major
    Found in lib/fog/aws/compute.rb - About 4 hrs to fix

      Method tagged_resources has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

              def tagged_resources(resources)
          Array(resources).map do |resource_id|
            if match = resource_id.match(/^(\w+)-[a-z0-9]{8,17}/i)
              id = match.captures.first
            else
      Severity: Minor
      Found in lib/fog/aws/compute.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setup_default_vpc! has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def setup_default_vpc!
          return if default_vpc.present?

          disable_ec2_classic
      Severity: Major
      Found in lib/fog/aws/compute.rb - About 2 hrs to fix

        Method _request has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

                def _request(body, headers, idempotent, parser, retries = 0)

          max_retries = 10

          begin
        Severity: Minor
        Found in lib/fog/aws/compute.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _request has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def _request(body, headers, idempotent, parser, retries = 0)

          max_retries = 10

          begin
        Severity: Minor
        Found in lib/fog/aws/compute.rb - About 1 hr to fix

          Method tagged_resources has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def tagged_resources(resources)
          Array(resources).map do |resource_id|
            if match = resource_id.match(/^(\w+)-[a-z0-9]{8,17}/i)
              id = match.captures.first
            else
          Severity: Minor
          Found in lib/fog/aws/compute.rb - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                      if @endpoint = options[:endpoint]
            endpoint = URI.parse(@endpoint)
            @host = endpoint.host or raise InvalidURIError.new("could not parse endpoint: #{@endpoint}")
            @path = endpoint.path
            @port = endpoint.port
            Severity: Major
            Found in lib/fog/aws/compute.rb - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                        if @endpoint = options[:endpoint]
            endpoint = URI.parse(@endpoint)
            @host = endpoint.host or raise InvalidURIError.new("could not parse endpoint: #{@endpoint}")
            @path = endpoint.path
            @port = endpoint.port
              Severity: Major
              Found in lib/fog/aws/compute.rb - About 1 hr to fix

                Method _request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        def _request(body, headers, idempotent, parser, retries = 0)
                Severity: Minor
                Found in lib/fog/aws/compute.rb - About 35 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                            if @endpoint = options[:endpoint]
            endpoint = URI.parse(@endpoint)
            @host = endpoint.host or raise InvalidURIError.new("could not parse endpoint: #{@endpoint}")
            @path = endpoint.path
            @port = endpoint.port
                  Severity: Major
                  Found in lib/fog/aws/compute.rb and 1 other location - About 1 hr to fix
                  lib/fog/aws/compute.rb on lines 325..337

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                            if @endpoint = options[:endpoint]
            endpoint = URI.parse(@endpoint)
            @host = endpoint.host or raise InvalidURIError.new("could not parse endpoint: #{@endpoint}")
            @path = endpoint.path
            @port = endpoint.port
                  Severity: Major
                  Found in lib/fog/aws/compute.rb and 1 other location - About 1 hr to fix
                  lib/fog/aws/compute.rb on lines 565..577

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                          def request(params)
          refresh_credentials_if_expired
          idempotent  = params.delete(:idempotent)
          parser      = params.delete(:parser)
                  Severity: Major
                  Found in lib/fog/aws/compute.rb and 3 other locations - About 1 hr to fix
                  lib/fog/aws/ecs.rb on lines 91..116
                  lib/fog/aws/elb.rb on lines 167..192
                  lib/fog/aws/rds.rb on lines 250..275

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 20 locations. Consider refactoring.
                  Open

                          def setup_credentials(options)
          @aws_access_key_id      = options[:aws_access_key_id]
          @aws_secret_access_key  = options[:aws_secret_access_key]
          @aws_session_token      = options[:aws_session_token]
          @aws_credentials_expire_at = options[:aws_credentials_expire_at]
                  Severity: Major
                  Found in lib/fog/aws/compute.rb and 19 other locations - About 20 mins to fix
                  lib/fog/aws/auto_scaling.rb on lines 175..181
                  lib/fog/aws/beanstalk.rb on lines 94..100
                  lib/fog/aws/cloud_formation.rb on lines 85..91
                  lib/fog/aws/cloud_watch.rb on lines 113..119
                  lib/fog/aws/data_pipeline.rb on lines 130..136
                  lib/fog/aws/dynamodb.rb on lines 95..101
                  lib/fog/aws/ecs.rb on lines 82..88
                  lib/fog/aws/efs.rb on lines 95..103
                  lib/fog/aws/elasticache.rb on lines 79..85
                  lib/fog/aws/emr.rb on lines 85..91
                  lib/fog/aws/glacier.rb on lines 199..205
                  lib/fog/aws/iam.rb on lines 285..293
                  lib/fog/aws/kinesis.rb on lines 59..65
                  lib/fog/aws/lambda.rb on lines 111..117
                  lib/fog/aws/rds.rb on lines 241..247
                  lib/fog/aws/redshift.rb on lines 93..99
                  lib/fog/aws/sns.rb on lines 108..114
                  lib/fog/aws/sqs.rb on lines 101..107
                  lib/fog/aws/support.rb on lines 110..118

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 27.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status