Sign upLogin

fog/fog-aws

View on GitHub
Star
lib/fog/aws/glacier.rb

Summary

Maintainability
B
6 hrs
Test Coverage
C
70%

Method digest_for_part has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def digest_for_part(body)
          part_stack = []
          part_temp = nil
          body_size = body.bytesize
          prepare_body_for_slice(body) {|body, slice|
Severity: Minor
Found in lib/fog/aws/glacier.rb - About 1 hr to fix

    Method digest_for_part has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def digest_for_part(body)
          part_stack = []
          part_temp = nil
          body_size = body.bytesize
          prepare_body_for_slice(body) {|body, slice|
    Severity: Minor
    Found in lib/fog/aws/glacier.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method reduce_digest_stack has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def reduce_digest_stack(digest, stack)
          stack.each_with_index{|s,i|
            unless digest
              digest = stack[i]
              next
    Severity: Minor
    Found in lib/fog/aws/glacier.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method prepare_body_for_slice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def prepare_body_for_slice(body)
          if body.respond_to? :byteslice
            r = yield(body, :byteslice)
          else
            if body.respond_to? :encoding
    Severity: Minor
    Found in lib/fog/aws/glacier.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            def initialize(options={})
          @use_iam_profile = options[:use_iam_profile]
          @region = options[:region] || 'us-east-1'

          setup_credentials(options)
    Severity: Major
    Found in lib/fog/aws/glacier.rb and 1 other location - About 2 hrs to fix
    lib/fog/aws/redshift.rb on lines 74..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 85.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 20 locations. Consider refactoring.
    Open

            def setup_credentials(options)
          @aws_access_key_id      = options[:aws_access_key_id]
          @aws_secret_access_key  = options[:aws_secret_access_key]
          @aws_session_token      = options[:aws_session_token]
          @aws_credentials_expire_at = options[:aws_credentials_expire_at]
    Severity: Major
    Found in lib/fog/aws/glacier.rb and 19 other locations - About 20 mins to fix
    lib/fog/aws/auto_scaling.rb on lines 175..181
    lib/fog/aws/beanstalk.rb on lines 94..100
    lib/fog/aws/cloud_formation.rb on lines 85..91
    lib/fog/aws/cloud_watch.rb on lines 113..119
    lib/fog/aws/compute.rb on lines 588..594
    lib/fog/aws/data_pipeline.rb on lines 130..136
    lib/fog/aws/dynamodb.rb on lines 95..101
    lib/fog/aws/ecs.rb on lines 82..88
    lib/fog/aws/efs.rb on lines 95..103
    lib/fog/aws/elasticache.rb on lines 79..85
    lib/fog/aws/emr.rb on lines 85..91
    lib/fog/aws/iam.rb on lines 285..293
    lib/fog/aws/kinesis.rb on lines 59..65
    lib/fog/aws/lambda.rb on lines 111..117
    lib/fog/aws/rds.rb on lines 241..247
    lib/fog/aws/redshift.rb on lines 93..99
    lib/fog/aws/sns.rb on lines 108..114
    lib/fog/aws/sqs.rb on lines 101..107
    lib/fog/aws/support.rb on lines 110..118

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status