Sign upLogin

fog/fog-aws

View on GitHub
Star
lib/fog/aws/requests/compute/register_image.rb

Summary

Maintainability
B
6 hrs
Test Coverage
D
60%

Method register_image has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def register_image(name, description, location, block_devices=[], options={})
          unless name.empty?
            image = {
              'imageId' => Fog::AWS::Mock.image_id,
              'imageLocation' => '',
Severity: Major
Found in lib/fog/aws/requests/compute/register_image.rb - About 2 hrs to fix

    Method register_image has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

            def register_image(name, description, location, block_devices=[], options={})
          unless name.empty?
            image = {
              'imageId' => Fog::AWS::Mock.image_id,
              'imageLocation' => '',
    Severity: Minor
    Found in lib/fog/aws/requests/compute/register_image.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method register_image has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def register_image(name, description, location, block_devices=[], options={})
          common_options = {
            'Action'      => 'RegisterImage',
            'Name'        => name,
            'Description' => description,
    Severity: Minor
    Found in lib/fog/aws/requests/compute/register_image.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method register_image has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def register_image(name, description, location, block_devices=[], options={})
    Severity: Minor
    Found in lib/fog/aws/requests/compute/register_image.rb - About 35 mins to fix

      Method register_image has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def register_image(name, description, location, block_devices=[], options={})
      Severity: Minor
      Found in lib/fog/aws/requests/compute/register_image.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status