Sign upLogin

fog/fog-aws

View on GitHub
Star
lib/fog/aws/requests/compute/run_instances.rb

Summary

Maintainability
C
1 day
Test Coverage
F
52%

Method run_instances has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def run_instances(image_id, min_count, max_count, options = {})
          response = Excon::Response.new
          response.status = 200

          group_set = [ (options['SecurityGroup'] || 'default') ].flatten
Severity: Major
Found in lib/fog/aws/requests/compute/run_instances.rb - About 4 hrs to fix

    Method run_instances has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

            def run_instances(image_id, min_count, max_count, options = {})
          if block_device_mapping = options.delete('BlockDeviceMapping')
            block_device_mapping.each_with_index do |mapping, index|
              for key, value in mapping
                options.merge!({ format("BlockDeviceMapping.%d.#{key}", index) => value })
    Severity: Minor
    Found in lib/fog/aws/requests/compute/run_instances.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run_instances has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def run_instances(image_id, min_count, max_count, options = {})
          if block_device_mapping = options.delete('BlockDeviceMapping')
            block_device_mapping.each_with_index do |mapping, index|
              for key, value in mapping
                options.merge!({ format("BlockDeviceMapping.%d.#{key}", index) => value })
    Severity: Major
    Found in lib/fog/aws/requests/compute/run_instances.rb - About 2 hrs to fix

      Method run_instances has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

              def run_instances(image_id, min_count, max_count, options = {})
          response = Excon::Response.new
          response.status = 200

          group_set = [ (options['SecurityGroup'] || 'default') ].flatten
      Severity: Minor
      Found in lib/fog/aws/requests/compute/run_instances.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status