Sign upLogin

fog/fog-aws

View on GitHub
Star
lib/fog/aws/requests/dns/list_resource_record_sets.rb

Summary

Maintainability
B
5 hrs
Test Coverage
B
81%

Method list_resource_record_sets has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def list_resource_record_sets(zone_id, options = {})
          maxitems = [options[:max_items]||100,100].min

          response = Excon::Response.new
Severity: Major
Found in lib/fog/aws/requests/dns/list_resource_record_sets.rb - About 2 hrs to fix

    Method list_all_records has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

            def list_all_records(record, zone, name)
          [].tap do |tmp_records|
            tmp_records.push(record) if !record[:name].nil? && ( name.nil? || record[:name].gsub(zone[:name],"") >= name)
            record.each do |key,subr|
              if subr.is_a?(Hash) && key.is_a?(String) &&
    Severity: Minor
    Found in lib/fog/aws/requests/dns/list_resource_record_sets.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method list_resource_record_sets has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            def list_resource_record_sets(zone_id, options = {})
          maxitems = [options[:max_items]||100,100].min

          response = Excon::Response.new
    Severity: Minor
    Found in lib/fog/aws/requests/dns/list_resource_record_sets.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status