Sign upLogin

fog/fog-aws

View on GitHub
Star
lib/fog/aws/requests/storage/put_bucket_notification.rb

Summary

Maintainability
A
2 hrs
Test Coverage
F
34%

Method put_bucket_notification has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def put_bucket_notification(bucket_name, notification)
          builder = Nokogiri::XML::Builder.new do
            NotificationConfiguration do
              notification.fetch('Topics', []).each do |topic|
                TopicConfiguration do
Severity: Minor
Found in lib/fog/aws/requests/storage/put_bucket_notification.rb - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          class Mock
        def put_bucket_notification(bucket_name, notification)
          response = Excon::Response.new

          if self.data[:buckets][bucket_name]
    Severity: Minor
    Found in lib/fog/aws/requests/storage/put_bucket_notification.rb and 1 other location - About 40 mins to fix
    lib/fog/aws/requests/storage/put_bucket_tagging.rb on lines 38..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              request({
            :body     => body,
            :expects  => 200,
            :headers  => {'Content-MD5' => Base64.encode64(OpenSSL::Digest::MD5.digest(body)).chomp!,
              'Content-Type' => 'application/xml'},
    Severity: Minor
    Found in lib/fog/aws/requests/storage/put_bucket_notification.rb and 2 other locations - About 20 mins to fix
    lib/fog/aws/requests/storage/put_bucket_lifecycle.rb on lines 86..93
    lib/fog/aws/requests/storage/put_bucket_tagging.rb on lines 27..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status