Sign upLogin

fog/fog-azure-rm

View on GitHub
Star

Showing 528 of 528 total issues

Use SCREAMING_SNAKE_CASE for constants.
Open

          Attach = 'attach'.freeze
Severity: Minor
Found in lib/fog/azurerm/models/compute/disk_create_option_types.rb by rubocop

This cop checks whether constant names are written using SCREAMINGSNAKECASE.

To avoid false positives, it ignores cases in which we cannot know for certain the type of value that would be assigned to a constant.

Example:

# bad
InchInCm = 2.54
INCHinCM = 2.54
Inch_In_Cm = 2.54

# good
INCH_IN_CM = 2.54

Use SCREAMING_SNAKE_CASE for constants.
Open

          Copy = 'Copy'.freeze
Severity: Minor
Found in lib/fog/azurerm/models/compute/disk_create_option.rb by rubocop

This cop checks whether constant names are written using SCREAMINGSNAKECASE.

To avoid false positives, it ignores cases in which we cannot know for certain the type of value that would be assigned to a constant.

Example:

# bad
InchInCm = 2.54
INCHinCM = 2.54
Inch_In_Cm = 2.54

# good
INCH_IN_CM = 2.54

Use SCREAMING_SNAKE_CASE for constants.
Open

          Restore = 'Restore'.freeze
Severity: Minor
Found in lib/fog/azurerm/models/compute/disk_create_option.rb by rubocop

This cop checks whether constant names are written using SCREAMINGSNAKECASE.

To avoid false positives, it ignores cases in which we cannot know for certain the type of value that would be assigned to a constant.

Example:

# bad
InchInCm = 2.54
INCHinCM = 2.54
Inch_In_Cm = 2.54

# good
INCH_IN_CM = 2.54

Use SCREAMING_SNAKE_CASE for constants.
Open

          None = 'None'.freeze
Severity: Minor
Found in lib/fog/azurerm/models/compute/caching_types.rb by rubocop

This cop checks whether constant names are written using SCREAMINGSNAKECASE.

To avoid false positives, it ignores cases in which we cannot know for certain the type of value that would be assigned to a constant.

Example:

# bad
InchInCm = 2.54
INCHinCM = 2.54
Inch_In_Cm = 2.54

# good
INCH_IN_CM = 2.54

Avoid rescuing without specifying an error class.
Open

            rescue => ex
Severity: Minor
Found in lib/fog/azurerm/requests/storage/create_disk.rb by rubocop

This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

Example: EnforcedStyle: implicit

# `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

Example: EnforcedStyle: explicit (default)

# `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

Carriage return character detected.
Open

module Fog
  module Network
Severity: Minor
Found in lib/fog/azurerm/models/network/load_balancer.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

                if lbr.is_a?(Hash)
Severity: Minor
Found in lib/fog/azurerm/models/network/load_balancer.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

            if frontend_ip_configurations.any?
Severity: Minor
Found in lib/fog/azurerm/models/network/load_balancer.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

%w-literals should be delimited by [ and ].
Open

        attribute :elastic_pool_name, aliases: %w(elasticPoolName)
Severity: Minor
Found in lib/fog/azurerm/models/sql/sql_database.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

%w-literals should be delimited by [ and ].
Open

        attribute :max_size_bytes, aliases: %w(maxSizeBytes)
Severity: Minor
Found in lib/fog/azurerm/models/sql/sql_database.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Missing top-level class documentation comment.
Open

      class Mock
Severity: Minor
Found in lib/fog/azurerm/requests/application_gateway/stop_application_gateway.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

%w-literals should be delimited by [ and ].
Open

              'peeringLocations' => %w(London Karachi),
Severity: Minor
Found in lib/fog/azurerm/requests/network/list_express_route_service_providers.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Unnecessary spacing detected.
Open

          rescue  MsRestAzure::AzureOperationError => e
Severity: Minor
Found in lib/fog/azurerm/requests/compute/deallocate_virtual_machine.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Prefer JSON.parse over JSON.load.
Open

          @network_client.deserialize(load_balancer_mapper, JSON.load(response), 'result.body')
Severity: Minor
Found in lib/fog/azurerm/requests/network/get_load_balancer.rb by rubocop

This cop checks for the use of JSON class methods which have potential security issues.

Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

Example:

# always offense
JSON.load("{}")
JSON.restore("{}")

# no offense
JSON.parse("{}")

Prefer JSON.parse over JSON.load.
Open

          @network_client.deserialize(gateway_mapper, JSON.load(response), 'result.body')
Severity: Minor
Found in lib/fog/azurerm/requests/application_gateway/get_application_gateway.rb by rubocop

This cop checks for the use of JSON class methods which have potential security issues.

Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

Example:

# always offense
JSON.load("{}")
JSON.restore("{}")

# no offense
JSON.parse("{}")

Prefer JSON.parse over JSON.load.
Open

          @network_client.deserialize(nsr_mapper, JSON.load(nsr), 'result.body')
Severity: Minor
Found in lib/fog/azurerm/requests/network/get_network_security_rule.rb by rubocop

This cop checks for the use of JSON class methods which have potential security issues.

Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

Example:

# always offense
JSON.load("{}")
JSON.restore("{}")

# no offense
JSON.parse("{}")

Unnecessary spacing detected.
Open

          rescue  MsRestAzure::AzureOperationError => e
Severity: Minor
Found in lib/fog/azurerm/requests/compute/redeploy_virtual_machine.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

%w-literals should be delimited by [ and ].
Open

                'nameServers' => %w(ns1-05.azure-dns.com. ns2-05.azure-dns.net. ns3-05.azure-dns.org. ns4-05.azure-dns.info.),
Severity: Minor
Found in lib/fog/azurerm/requests/dns/create_or_update_zone.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Missing top-level class documentation comment.
Open

      class Real
Severity: Minor
Found in lib/fog/azurerm/requests/application_gateway/stop_application_gateway.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Unnecessary spacing detected.
Open

          rescue  MsRestAzure::AzureOperationError => e
Severity: Minor
Found in lib/fog/azurerm/requests/resources/create_deployment.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"
Severity
Category
Status
Source
Language