Sign upLogin

fog/fog-azure-rm

View on GitHub
Star

Showing 528 of 528 total issues

Prefer JSON.parse over JSON.load.
Open

          @network_client.deserialize(network_security_rule_mapper, JSON.load(network_security_rule), 'result.body')
Severity: Minor
Found in lib/fog/azurerm/requests/network/create_or_update_network_security_rule.rb by rubocop

This cop checks for the use of JSON class methods which have potential security issues.

Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

Example:

# always offense
JSON.load("{}")
JSON.restore("{}")

# no offense
JSON.parse("{}")

Put empty method definitions on a single line.
Open

        def create_load_balancer(_name, _location, _resource_group, _frontend_ip_configuration_name, _subnet_id, _private_ip_address, _private_ip_allocation_method, _public_ip_address_id, _backend_address_pool_names, _load_balancing_rules, _probes, _inbound_nat_rules, _inbound_nat_pools)
        end
Severity: Minor
Found in lib/fog/azurerm/requests/network/create_load_balancer.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Unnecessary spacing detected.
Open

          rescue  MsRestAzure::AzureOperationError => e
Severity: Minor
Found in lib/fog/azurerm/requests/resources/list_deployments.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

%w-literals should be delimited by [ and ].
Open

                'advertisedpublicprefixes' => %w(prefix1 prefix2),
Severity: Minor
Found in lib/fog/azurerm/requests/network/get_express_route_circuit_peering.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Use 2 (not 0) spaces for indentation.
Open

            raise_azure_exception(e, msg)
Severity: Minor
Found in lib/fog/azurerm/requests/compute/attach_data_disk_to_vm.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

Unused method argument - async. If it's necessary, use _ or _async as an argument name to indicate that it won't be used.
Open

        def check_vm_status(resource_group, name, async)
Severity: Minor
Found in lib/fog/azurerm/requests/compute/check_vm_status.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Put empty method definitions on a single line.
Open

        def create_or_update_application_gateway(*)
        end
Severity: Minor
Found in lib/fog/azurerm/requests/application_gateway/create_or_update_application_gateway.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Put empty method definitions on a single line.
Open

        def update_sku_attributes(*)
        end
Severity: Minor
Found in lib/fog/azurerm/requests/application_gateway/update_sku_attributes.rb by rubocop

This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

Note: A method definition is not considered empty if it contains comments.

Example: EnforcedStyle: compact (default)

# bad
def foo(bar)
end

def self.foo(bar)
end

# good
def foo(bar); end

def foo(bar)
  # baz
end

def self.foo(bar); end

Example: EnforcedStyle: expanded

# bad
def foo(bar); end

def self.foo(bar); end

# good
def foo(bar)
end

def self.foo(bar)
end

Carriage return character detected.
Open

module Fog
  module Network
Severity: Minor
Found in lib/fog/azurerm/requests/network/remove_security_rule.rb by rubocop

Unnecessary spacing detected.
Open

          rescue  MsRestAzure::AzureOperationError => e
Severity: Minor
Found in lib/fog/azurerm/requests/resources/delete_resource_group.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Unnecessary spacing detected.
Open

          rescue  MsRestAzure::AzureOperationError => e
Severity: Minor
Found in lib/fog/azurerm/requests/compute/redeploy_virtual_machine.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Prefer JSON.parse over JSON.load.
Open

          @network_client.deserialize(gateway_mapper, JSON.load(response), 'result.body')
Severity: Minor
Found in lib/fog/azurerm/requests/application_gateway/get_application_gateway.rb by rubocop

This cop checks for the use of JSON class methods which have potential security issues.

Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

Example:

# always offense
JSON.load("{}")
JSON.restore("{}")

# no offense
JSON.parse("{}")

%w-literals should be delimited by [ and ].
Open

              'peeringLocations' => %w(London Karachi),
Severity: Minor
Found in lib/fog/azurerm/requests/network/list_express_route_service_providers.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Carriage return character detected.
Open

module Fog
  module Network
Severity: Minor
Found in lib/fog/azurerm/requests/network/get_network_interface.rb by rubocop

Unnecessary spacing detected.
Open

          rescue  MsRestAzure::AzureOperationError => e
Severity: Minor
Found in lib/fog/azurerm/requests/resources/create_deployment.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Carriage return character detected.
Open

module Fog
  module Network
Severity: Minor
Found in lib/fog/azurerm/requests/network/delete_load_balancer.rb by rubocop

Do not prefix writer method names with set_.
Open

        def set_connection_shared_key(*)
Severity: Minor
Found in lib/fog/azurerm/requests/network/set_connection_shared_key.rb by rubocop

This cop makes sure that accessor methods are named properly.

Example:

# bad
def set_attribute(value)
end

# good
def attribute=(value)
end

# bad
def get_attribute
end

# good
def attribute
end

Unnecessary spacing detected.
Open

          rescue  MsRestAzure::AzureOperationError => e
Severity: Minor
Found in lib/fog/azurerm/requests/network/delete_load_balancer.rb by rubocop

This cop checks for extra/unnecessary whitespace.

Example:

# good if AllowForAlignment is true
name      = "RuboCop"
# Some comment and an empty line

website  += "/bbatsov/rubocop" unless cond
puts        "rubocop"          if     debug

# bad for any configuration
set_app("RuboCop")
website  = "https://github.com/bbatsov/rubocop"

Carriage return character detected.
Open

module Fog
  module Network
Severity: Minor
Found in lib/fog/azurerm/requests/network/list_load_balancers.rb by rubocop

Carriage return character detected.
Open

module Fog
  module Network
Severity: Minor
Found in lib/fog/azurerm/requests/network/add_security_rules.rb by rubocop
Severity
Category
Status
Source
Language