Sign upLogin

fog/fog-azure-rm

View on GitHub
Star
lib/fog/azurerm/models/network/express_route_circuit.rb

Summary

Maintainability
A
1 hr
Test Coverage
F
47%

Method parse has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def self.parse(circuit)
          express_route_circuit = {}
          express_route_circuit['id'] = circuit.id
          express_route_circuit['name'] = circuit.name
          express_route_circuit['location'] = circuit.location
Severity: Minor
Found in lib/fog/azurerm/models/network/express_route_circuit.rb - About 1 hr to fix

    Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def self.parse(circuit)
          express_route_circuit = {}
          express_route_circuit['id'] = circuit.id
          express_route_circuit['name'] = circuit.name
          express_route_circuit['location'] = circuit.location
    Severity: Minor
    Found in lib/fog/azurerm/models/network/express_route_circuit.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Favor a normal unless-statement over a modifier clause in a multiline statement.
    Open

              circuit.peerings.each do |peering|
            circuit_peering = Fog::Network::AzureRM::ExpressRouteCircuitPeering.new
            express_route_circuit['peerings'] << circuit_peering.merge_attributes(Fog::Network::AzureRM::ExpressRouteCircuitPeering.parse(peering))
          end unless circuit.peerings.nil?
    Severity: Minor
    Found in lib/fog/azurerm/models/network/express_route_circuit.rb by rubocop

    Checks for uses of if/unless modifiers with multiple-lines bodies.

    Example:

    # bad
{
  result: 'this should not happen'
} unless cond

# good
{ result: 'ok' } if cond

    There are no issues that match your filters.

    Category
    Status