fog/fog-azure-rm

View on GitHub
lib/fog/azurerm/models/network/express_route_service_provider.rb

Summary

Maintainability
A
0 mins
Test Coverage
F
47%

Favor a normal unless-statement over a modifier clause in a multiline statement.
Open

          service_provider.peering_locations.each do |peering_location|
            express_route_service_provider['peering_locations'] << peering_location
          end unless service_provider.peering_locations.nil?

Checks for uses of if/unless modifiers with multiple-lines bodies.

Example:

# bad
{
  result: 'this should not happen'
} unless cond

# good
{ result: 'ok' } if cond

Favor a normal unless-statement over a modifier clause in a multiline statement.
Open

          service_provider.bandwidths_offered.each do |bandwidth_offered|
            express_route_service_provider['bandwidths_offered'] << bandwidth_offered
          end unless service_provider.bandwidths_offered.nil?

Checks for uses of if/unless modifiers with multiple-lines bodies.

Example:

# bad
{
  result: 'this should not happen'
} unless cond

# good
{ result: 'ok' } if cond

There are no issues that match your filters.

Category
Status