fog/fog-azure-rm

View on GitHub
lib/fog/azurerm/requests/application_gateway/create_or_update_application_gateway.rb

Summary

Maintainability
B
4 hrs
Test Coverage
F
9%

File create_or_update_application_gateway.rb has 256 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Fog
  module ApplicationGateway
    class AzureRM
      # Real class for Application Gateway Request
      class Real

    Method define_application_gateway has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

            def define_application_gateway(gateway_params)
              application_gateway = Azure::ARM::Network::Models::ApplicationGateway.new
              application_gateway.name = gateway_params[:name]
              application_gateway.location = gateway_params[:location]
    
    

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method define_request_routing_rules has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def define_request_routing_rules(request_routing_rules)
              request_routing_rule_arr = []
    
              request_routing_rules.each do |rule|
                request_routing_rule = Azure::ARM::Network::Models::ApplicationGatewayRequestRoutingRule.new

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method define_http_listeners has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def define_http_listeners(http_listeners)
              http_listener_arr = []
    
              http_listeners.each do |listener|
                http_listener = Azure::ARM::Network::Models::ApplicationGatewayHttpListener.new

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method define_url_path_maps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def define_url_path_maps(url_path_maps)
              url_path_map_arr = []
    
              url_path_maps.each do |map|
                url_path_map = Azure::ARM::Network::Models::ApplicationGatewayUrlPathMap.new

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Put empty method definitions on a single line.
    Open

            def create_or_update_application_gateway(*)
            end

    This cop checks for the formatting of empty method definitions. By default it enforces empty method definitions to go on a single line (compact style), but it can be configured to enforce the end to go on its own line (expanded style).

    Note: A method definition is not considered empty if it contains comments.

    Example: EnforcedStyle: compact (default)

    # bad
    def foo(bar)
    end
    
    def self.foo(bar)
    end
    
    # good
    def foo(bar); end
    
    def foo(bar)
      # baz
    end
    
    def self.foo(bar); end

    Example: EnforcedStyle: expanded

    # bad
    def foo(bar); end
    
    def self.foo(bar); end
    
    # good
    def foo(bar)
    end
    
    def self.foo(bar)
    end

    There are no issues that match your filters.

    Category
    Status