fog/fog-azure-rm

View on GitHub
lib/fog/azurerm/requests/application_gateway/get_application_gateway.rb

Summary

Maintainability
B
5 hrs
Test Coverage
F
43%

Method get_application_gateway has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def get_application_gateway(*)
          response = '{
            "id": "/subscriptions/{guid}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/applicationGateways/gateway",
            "name": "gateway",
            "type": "Microsoft.Network/applicationGateways",

    Prefer JSON.parse over JSON.load.
    Open

              @network_client.deserialize(gateway_mapper, JSON.load(response), 'result.body')

    This cop checks for the use of JSON class methods which have potential security issues.

    Autocorrect is disabled by default because it's potentially dangerous. If using a stream, like JSON.load(open('file')), it will need to call #read manually, like JSON.parse(open('file').read). If reading single values (rather than proper JSON objects), like JSON.load('false'), it will need to pass the quirks_mode: true option, like JSON.parse('false', quirks_mode: true). Other similar issues may apply.

    Example:

    # always offense
    JSON.load("{}")
    JSON.restore("{}")
    
    # no offense
    JSON.parse("{}")

    There are no issues that match your filters.

    Category
    Status